Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis fix: rabbitmq key update (travis msg broker) #8944

Merged
merged 2 commits into from Dec 3, 2018
Merged

Travis fix: rabbitmq key update (travis msg broker) #8944

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13822a4
travis: mangodb key update not needed anymore
0xc0170 Dec 3, 2018
9b4be1b
travis: rabbitmq signature update
0xc0170 Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -30,8 +30,8 @@ before_install:
# Setup ppa to make sure arm-none-eabi-gcc is correct version
- sudo add-apt-repository -y ppa:team-gcc-arm-embedded/ppa
- sudo add-apt-repository -y ppa:deadsnakes/ppa
# Fix for "The following signatures were invalid: KEYEXPIRED 1515625755" failed". See https://github.com/travis-ci/travis-ci/issues/9037
- sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv 0C49F3730359A14518585931BC711F9BA15703C6
# import the new keys for rabbitmq (fix for https://github.com/ARMmbed/mbed-os/issues/8945)
- curl -s https://packagecloud.io/install/repositories/rabbitmq/rabbitmq-server/script.deb.sh | sudo bash
Copy link
Contributor

@cmonr cmonr Dec 3, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😥

Blindly downloading a shell script and piping into bash should never be considered a fix.

Unfortunately, I don't know of any other way to fix this aside from Travis CI fixing the issue on their side. This at least allows us to progress PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows https://packagecloud.io/rabbitmq/rabbitmq-server/install . Let's rewrite this or report to travis to actually update it on their side

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to: #8950

# Loop until update succeeds (timeouts can occur)
- travis_retry $(! sudo apt-get update 2>&1 |grep Failed)

Expand Down