Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cordio Nordic memory optimizations #8981

Merged
merged 12 commits into from Dec 7, 2018
Merged

Cordio Nordic memory optimizations #8981

merged 12 commits into from Dec 7, 2018

Conversation

donatieng
Copy link
Contributor

@donatieng donatieng commented Dec 5, 2018 •
edited

Description

Fix for https://github.com/MarceloSalazar/mbed-os-example-ble-HeartRate/issues/2; JIRA: IOTPAN-315

This PR fixes two issues:

  • The Cordio Link Layer initialisation requests too much memory on the NRF52832/810 platforms, we reduced memory requirements not these platforms
  • When allocating a custom memory pool in a HCI Driver, the default pool is still allocated as it's statically allocated within part a virtual method (not eliminated but the linker) - to circumvent this we made this method pure virtual and still provided this default pool with a convenience method

HCI Drivers updated for the following platforms:

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@donatieng donatieng changed the title Cordio nordic memory optimizations Cordio Nordic memory optimizations Dec 5, 2018
@donatieng donatieng requested a review from a team December 5, 2018 19:46
@cmonr
Copy link
Contributor

cmonr commented Dec 5, 2018

@donatieng Are there links to the issues referenced?

@donatieng donatieng mentioned this pull request Dec 5, 2018
Open
@donatieng
Copy link
Contributor Author

Updated description, the issue is https://github.com/MarceloSalazar/mbed-os-example-ble-HeartRate/issues/2

@cmonr
Copy link
Contributor

cmonr commented Dec 5, 2018

Weird. Dunno why @MarceloSalazar cloned the repo...

pan-
pan- requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change set, we need to investigate the impact of every option to provide detailed configuration option.

features/FEATURE_BLE/targets/TARGET_CORDIO/driver/CordioHCIDriver.h Outdated Show resolved Hide resolved
@donatieng donatieng mentioned this pull request Dec 6, 2018
Closed
@pan-
Update features/FEATURE_BLE/targets/TARGET_CORDIO/driver/CordioHCIDri…
e3d8b28 
…ver.h


Fix doxygen as suggested by @pan-

Co-Authored-By: donatieng <donatien.garnier@arm.com>
@0xc0170 0xc0170 requested a review from melwee01 December 6, 2018 10:35
@cmonr
Copy link
Contributor

cmonr commented Dec 6, 2018

Waiting on @ARMmbed/mbed-docs before starting CI

Amanda Butler added 2 commits December 6, 2018 13:22
Edit CordioHCIDriver.h
61c2599 
Edit file for active voice.
Edit PortingGuide.md
aa4b5a5 
Edit file for active voice.
AnotherButler
AnotherButler approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. If there's a porting component, I'm surprised it doesn't belong in our rendered docs.

@cmonr
Copy link
Contributor

cmonr commented Dec 6, 2018

CI started

@cmonr cmonr added the needs: CI label Dec 6, 2018
@mbed-ci
Copy link

mbed-ci commented Dec 7, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 73db5da into ARMmbed:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

@melwee01 melwee01 Awaiting requested review from melwee01

Assignees
No one assigned
Labels
release-version: 5.11.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@donatieng @cmonr @mbed-ci @pan- @0xc0170 @AnotherButler