Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust FAT FS tests to low memory boards #8990

Merged
merged 1 commit into from Dec 17, 2018
Merged

Adjust FAT FS tests to low memory boards #8990

merged 1 commit into from Dec 17, 2018

Conversation

davidsaada
Copy link
Contributor

Description

This PR adjusts the FAT FS tests (regular and multipart) to small boards. This is achieved by checking whether the board can allocate a certain memory chunk (threshold) and skipping the test if it can't. This should prevent these boards from failing in CI.

Resolves #7407.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@davidsaada
Copy link
Contributor Author

@jeromecoutant Please check whether this PR fixes the failures on your boards, as I don't have any of the available for testing.

@0xc0170 0xc0170 requested review from a team and removed request for jeromecoutant December 12, 2018 15:08
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 12, 2018

@jeromecoutant Please check whether this PR fixes the failures on your boards, as I don't have any of the available for testing.

Does it fix @jeromecoutant ?

@0xc0170 0xc0170 requested a review from a team December 13, 2018 13:20
0xc0170
0xc0170 requested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit msg should contain some of these details

This PR adjusts the FAT FS tests (regular and multipart) to small boards. This is achieved by checking whether the board can allocate a certain memory chunk (threshold) and skipping the test if it can't. This should prevent these boards from failing in CI.

Adjust FAT FS tests to low memory boards
713b470 
This is achieved by checking whether the board can allocate a certain memory
chunk (threshold) and skipping the test if it can't.
This should prevent these boards from failing in CI.
@davidsaada
Copy link
Contributor Author

Commit msg should contain some of these details

Commit message fixed.

@cmonr
Copy link
Contributor

cmonr commented Dec 14, 2018

@davidsaada Mind poking others on your team for a quick review?

@davidsaada
Copy link
Contributor Author

@yossi2le @offirko Can any of you review?

offirko
offirko approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@offirko offirko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NirSonnenschein
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 2697913 into ARMmbed:master Dec 17, 2018
@davidsaada davidsaada deleted the david_fat_tests_low_mem branch January 14, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@offirko offirko offirko approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@davidsaada @0xc0170 @cmonr @NirSonnenschein @mbed-ci @jeromecoutant @offirko