Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: add license #9047

Merged
merged 1 commit into from
Dec 12, 2018
Merged

travis: add license #9047

merged 1 commit into from
Dec 12, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Dec 11, 2018

Description

Add license to the travis as this is custom made script. Created 2013

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team December 11, 2018 10:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feels weird to have this header in a YAML file.

LGTM

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 11, 2018

Still feels weird to have this header in a YAML file.

I noticed some random projects also license it. For instance we can't do this to .json files. So if YAML supports it, why not.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 12, 2018

CI started

@0xc0170 0xc0170 merged commit 7c5cffb into ARMmbed:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xc0170 @ciarmcom @cmonr