-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable stats reporting with a flag in targets.json #9072
Conversation
### Description PR ARMmbed#8607 will cause problems for the NRF52832 and the NRF52840 in the online compiler starting with 5.10.2. This PR prevents this problem by using a toggle in `targets.json` to enable these new defines for every target except for the NRF52832 and NRF52840. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@ARMmbed/mbed-os-pan you should be aware of this |
Could we get details on build failures - could not reproduce? |
@donatieng No build failures occur. |
@deepikabhavnani It has not caused problems yet, which is why that sentence is future tense. Also, you're assuming that the online compiler somehow can use the build tools in the same way as Mbed CLI. It does not, and only uses a single copy of the tools that is near latest. |
Wow, didn't knew that tools are |
So just to make sure I understand, this problem:
|
CI started |
Nope. At no point does anything overflow RAM or allocate outside of RAM. The problem is that the Softdevice and Application allocate the same RAM when the Softdevice is used. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Jimmy. Do you plan to add a bit of documentation about this feature for partners that may encounter the same situation in the future ?
@pan- That's a good idea. I'll add it to the adding and configuring targets section. |
Description
PR #8607 will cause problems for the NRF52832 and the NRF52840
in the online compiler starting with 5.10.2. This PR prevents this problem
by using a toggle in
targets.json
to enable these new defines for everytarget except for the NRF52832 and NRF52840.
Update: BLE + Softdevice + NRF528XX is currently broken in master, and this will work around it for the time being by not enabling the memory-reporting for the NRF528XX targets.
Pull request type