Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoRaWAN: Retiring LoRaWANBase class #9219

Merged
merged 4 commits into from
Feb 21, 2019
Merged

LoRaWAN: Retiring LoRaWANBase class #9219

merged 4 commits into from
Feb 21, 2019

Commits on Jan 10, 2019

  1. Retiring LoRaWANBase class 

    It was decided within the team to retire LoRaWANBase class which served
as a pure virtual interface class from which LoRaWAN network stack
implementations would get inherited. However, the current view is that
we may be the only user of it so we could retire LoRaWANBase.
    Hasnain Virk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    b9b414a View commit details
    Browse the repository at this point in the history

  2. Deprecation notice for LoRaWANBase 

    A deprecation notice has been added for any users of LoRaWANBase and any
existing reference is redirected to LoRaWANInterface.
    Hasnain Virk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    ef1baa3 View commit details
    Browse the repository at this point in the history

  3. Removing virtual modifier from LoRaWANInterface 

    Doing away with virtual modifier from LoRaWANInterface, gets rid of
vtable for LoRaWANInterface.
    Hasnain Virk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    2b95fd3 View commit details
    Browse the repository at this point in the history

  4. Doxygen corrections 

    Adding group identidier so that LoRaWANInterface class goes to the class
hierarchy section rather than data-structures.

Adding missing documentation for a couple of public functions.

Adding \code and \endcode modifiers for the example code in the
documentation.

Adding compile time NO_DOXYGEN flag for the implementations of the
LoRaPHY Class.

Adding documentation for some of the private structures.
    Hasnain Virk committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    5fb383c View commit details
    Browse the repository at this point in the history