Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: fix missing null checks on Gap event handler #9399

Merged
merged 2 commits into from Jan 21, 2019
Merged

BLE: fix missing null checks on Gap event handler #9399

merged 2 commits into from Jan 21, 2019

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jan 16, 2019 •
edited

Description

There are two missing null checks for the event handler. This may cause a hardfault as the event handler is optional.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@paul-szczepanek-arm paul-szczepanek-arm changed the title BLE fix missing null checks on event handler BLE: fix missing null checks on Gap event handler Jan 16, 2019
@cmonr cmonr requested a review from donatieng January 16, 2019 23:47
@paul-szczepanek-arm
Copy link
Member Author

Ready for CI

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

Ready for CI

Anyone from @ARMmbed/mbed-os-pan review?

@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 4019efb into ARMmbed:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@pan- pan- pan- approved these changes

@donatieng donatieng Awaiting requested review from donatieng

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paul-szczepanek-arm @0xc0170 @cmonr @mbed-ci @pan- @donatieng