Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newlines at end of files #9474

Merged
merged 4 commits into from Jan 28, 2019
Merged

Fix newlines at end of files #9474

merged 4 commits into from Jan 28, 2019

Conversation

VeijoPesonen
Copy link
Contributor

Description

To avoid unnecessary compiler warnings add newlines.

L3IPInterface: make inheriting virtual explicit to avoid compiler warning with ARMC5.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-ipcore

@ciarmcom ciarmcom requested review from a team January 23, 2019 16:00
@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

davidsaada
davidsaada approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 28, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit f5730a9 into ARMmbed:master Jan 28, 2019
@adbridge
Copy link
Contributor

adbridge commented Feb 8, 2019

This could have come into 5.11.4 if it wasn't for the changing of L3IPInterface: make inheriting virtual explicit which changes code only introduced for 5.12. That is the danger of mixing unrelated code changes. Shouldn't really be mixing purely documentation changes with an actual code change. This will now have to go to 5.12

@VeijoPesonen VeijoPesonen deleted the fix-newlines_at_end-of-files branch September 6, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@davidsaada davidsaada davidsaada approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@VeijoPesonen @ciarmcom @0xc0170 @mbed-ci @adbridge @pan- @SeppoTakalo @davidsaada @michalpasztamobica @cmonr