Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newlines at end of files #9474

Merged
merged 4 commits into from Jan 28, 2019

Conversation

Projects
None yet
10 participants
@VeijoPesonen
Copy link
Contributor

commented Jan 23, 2019

Description

To avoid unnecessary compiler warnings add newlines.

L3IPInterface: make inheriting virtual explicit to avoid compiler warning with ARMC5.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-ipcore

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jan 23, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

@davidsaada
Copy link
Contributor

left a comment

LGTM.

@pan-

pan- approved these changes Jan 23, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 28, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 28, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit f5730a9 into ARMmbed:master Jan 28, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9345 cycles (+33 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jan 28, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

This could have come into 5.11.4 if it wasn't for the changing of L3IPInterface: make inheriting virtual explicit which changes code only introduced for 5.12. That is the danger of mixing unrelated code changes. Shouldn't really be mixing purely documentation changes with an actual code change. This will now have to go to 5.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.