Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yotta references within testing frameworks #9527

Merged
merged 4 commits into from Jan 31, 2019

Conversation

Projects
None yet
7 participants
@bridadan
Copy link
Contributor

bridadan commented Jan 28, 2019

Description

Doing some clean up of some old Mbed OS 3 references in this code base. The references can cause some confusion (see #6417, ARMmbed/mbed-os-5-docs#462 (comment)).

Specifically removed usage of yotta cfg macros, minar functions, and anything related to the mbed-drivers package.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jan 29, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 29, 2019

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@bridadan bridadan force-pushed the bridadan:remove_yotta_references branch to 4a0bb5b Jan 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 29, 2019

@screamerbg @MarceloSalazar Are y'all ok with this?

@cmonr

cmonr approved these changes Jan 29, 2019

Copy link
Contributor

cmonr left a comment

LGTM, but also asking people who interface with partners for OK as well

@screamerbg

This comment has been minimized.

Copy link
Member

screamerbg commented Jan 29, 2019

LGTM

Comments addressed. Please re-review.

@cmonr cmonr added needs: CI and removed needs: review labels Jan 30, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 30, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7c578cf into ARMmbed:master Jan 31, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-24 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10049 cycles (+316 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.