Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yotta references within testing frameworks #9527

Merged
merged 4 commits into from Jan 31, 2019
Merged

Remove yotta references within testing frameworks #9527

merged 4 commits into from Jan 31, 2019

Conversation

bridadan
Copy link
Contributor

Description

Doing some clean up of some old Mbed OS 3 references in this code base. The references can cause some confusion (see #6417, ARMmbed/mbed-os-5-docs#462 (comment)).

Specifically removed usage of yotta cfg macros, minar functions, and anything related to the mbed-drivers package.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from a team January 29, 2019 00:00
@ciarmcom
Copy link
Member

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2019

@screamerbg @MarceloSalazar Are y'all ok with this?

cmonr
cmonr approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also asking people who interface with partners for OK as well

@screamerbg
Copy link
Contributor

LGTM

@cmonr cmonr dismissed 0xc0170’s stale review January 30, 2019 22:38

Comments addressed. Please re-review.

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7c578cf into ARMmbed:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bridadan @ciarmcom @cmonr @screamerbg @mbed-ci @0xc0170 @NirSonnenschein