Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features: nanostack: fix warning in thread_extension.h #9696

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
6 participants
@naveenkaje
Copy link
Contributor

naveenkaje commented Feb 12, 2019

Description

Fix the following build warning seen with GCC

Compile [ 51.2%]: thread_bootstrap.c
[Warning] thread_extension.h@88,44: statement with no effect [-Wunused-value]

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 13, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 13, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 13, 2019

@naveenkaje The string of PRs that you created today (https://github.com/ARMmbed/mbed-os/pulls/naveenkaje), they all referenced warning present when building with GCC.

Do the warnings also go away with the ARM and IAR compilers?

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 13, 2019

@cmonr is another review required here?

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Feb 13, 2019

@0xc0170
Copy link
Member

0xc0170 left a comment

100644 → 100755

File permission needs revert
Thanks for pointing it.
The fix looks fine, a question is about the line 90 - not triggering this warning also?

No, line 90 is not flagged.

features: nanostack: fix warning in thread_extension.h
Fix the following build warning seen with GCC

Compile [ 51.2%]: thread_bootstrap.c
[Warning] thread_extension.h@88,44: statement with no effect [-Wunused-value]

@naveenkaje naveenkaje force-pushed the naveenkaje:thread_extn_warning_fix branch to 1f015aa Feb 13, 2019

@cmonr cmonr added needs: CI and removed needs: work labels Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 13, 2019

@NirSonnenschein Not really since the change seems so minor.

@naveenkaje

Do the warnings also go away with the ARM and IAR compilers?

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

Attribute updated.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 14, 2019

@cmonr cmonr merged commit b66678d into ARMmbed:master Feb 14, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10429 cycles (+1084 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.