Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

features: nanostack: fix warning in thread_extension.h #9696

Merged
merged 1 commit into from
Feb 14, 2019
Merged

features: nanostack: fix warning in thread_extension.h #9696

merged 1 commit into from
Feb 14, 2019

Conversation

naveenkaje
Copy link
Contributor

Description

Fix the following build warning seen with GCC

Compile [ 51.2%]: thread_bootstrap.c
[Warning] thread_extension.h@88,44: statement with no effect [-Wunused-value]

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team February 13, 2019 00:00
@ciarmcom
Copy link
Member

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

@naveenkaje The string of PRs that you created today (https://github.com/ARMmbed/mbed-os/pulls/naveenkaje), they all referenced warning present when building with GCC.

Do the warnings also go away with the ARM and IAR compilers?

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

@cmonr is another review required here?

0xc0170
0xc0170 previously requested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited by naveenkaje
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100644 → 100755

File permission needs revert
Thanks for pointing it.
The fix looks fine, a question is about the line 90 - not triggering this warning also?

No, line 90 is not flagged.

features: nanostack: fix warning in thread_extension.h
1f015aa 
Fix the following build warning seen with GCC

Compile [ 51.2%]: thread_bootstrap.c
[Warning] thread_extension.h@88,44: statement with no effect [-Wunused-value]
@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

@NirSonnenschein Not really since the change seems so minor.

@naveenkaje

Do the warnings also go away with the ARM and IAR compilers?

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

CI started

@cmonr cmonr dismissed 0xc0170’s stale review February 13, 2019 20:41

Attribute updated.

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit b66678d into ARMmbed:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@naveenkaje @ciarmcom @cmonr @mbed-ci @NirSonnenschein @0xc0170