Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: fixed initialisation order in GattServer #9763

Merged
merged 1 commit into from
Feb 20, 2019
Merged

BLE: fixed initialisation order in GattServer #9763

merged 1 commit into from
Feb 20, 2019

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Feb 19, 2019 •
edited
Loading

Description

Fixed member initialisation order which will result in a warning or even error depending on compiler.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@donatieng

@paul-szczepanek-arm paul-szczepanek-arm changed the title fixed initialisation order BLE: fixed initialisation order Feb 19, 2019
@paul-szczepanek-arm paul-szczepanek-arm changed the title BLE: fixed initialisation order BLE: fixed initialisation order in GattServer Feb 19, 2019
cmonr
cmonr approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@cmonr cmonr requested a review from donatieng February 19, 2019 17:53
@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

@donatieng A quick one 😃

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI job restarted: jenkins-ci/exporter

Failure did not appear to be related to PR.

@0xc0170 0xc0170 merged commit 4b83fe1 into ARMmbed:master Feb 20, 2019
@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

Ah, there we go. This is sitting on top of #9537

Retargeted for 5.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@pan- pan- pan- approved these changes

@donatieng donatieng donatieng approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paul-szczepanek-arm @cmonr @mbed-ci @pan- @donatieng @0xc0170