Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fixed initialisation order in GattServer #9763

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
6 participants
@paul-szczepanek-arm
Copy link
Member

commented Feb 19, 2019

Description

Fixed member initialisation order which will result in a warning or even error depending on compiler.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@donatieng

@paul-szczepanek-arm paul-szczepanek-arm changed the title fixed initialisation order BLE: fixed initialisation order Feb 19, 2019

@paul-szczepanek-arm paul-szczepanek-arm changed the title BLE: fixed initialisation order BLE: fixed initialisation order in GattServer Feb 19, 2019

@cmonr

cmonr approved these changes Feb 19, 2019

Copy link
Contributor

left a comment

😁

@cmonr cmonr requested a review from donatieng Feb 19, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

@donatieng A quick one 😃

@cmonr cmonr added the needs: review label Feb 19, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

CI started

@pan-

pan- approved these changes Feb 19, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 19, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

CI job restarted: jenkins-ci/exporter

Failure did not appear to be related to PR.

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 19, 2019

@0xc0170 0xc0170 merged commit 4b83fe1 into ARMmbed:master Feb 20, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10538 cycles (+140 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Ah, there we go. This is sitting on top of #9537

Retargeted for 5.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.