Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IAR8 binaries for USI_WM_BN_BM_22 and EMW3166 based chips #9847

Closed
wants to merge 1 commit into from
Closed

Add IAR8 binaries for USI_WM_BN_BM_22 and EMW3166 based chips #9847

wants to merge 1 commit into from

Conversation

SeppoTakalo
Copy link
Contributor

Description

Add IAR8 binaries for USI_WM_BN_BM_22 and EMW3166 based chips

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 @deepikabhavnani

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2019

I am missing binaries in this PR.

@SeppoTakalo
Copy link
Contributor Author

Force pushed the missing binaries.. Sorry. I accidentally did not add those to original commit.

@deepikabhavnani deepikabhavnani mentioned this pull request Feb 26, 2019
Merged
@ciarmcom ciarmcom requested review from 0xc0170, deepikabhavnani and a team February 26, 2019 14:00
@ciarmcom
Copy link
Member

@SeppoTakalo, thank you for your changes.
@deepikabhavnani @0xc0170 @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine but why "uARM" is being removed?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2019

looks fine but why "uARM" is being removed?

incorrectly defined previously is the answer.
As we might have one more fix for IAR8 soon, we might merge this one into one PR that would fix few issues we identified today

@deepikabhavnani deepikabhavnani mentioned this pull request Feb 26, 2019
Merged
@deepikabhavnani
Copy link

Roll up PR is created for this change to perform CI testing. #9858

@deepikabhavnani deepikabhavnani mentioned this pull request Feb 26, 2019
Closed
21 tasks
@cmonr
Copy link
Contributor

cmonr commented Feb 26, 2019

Closing since PR commit has been brought into the rollup which is now in master (6d04fa7)

This wasn't auto-closed since the commits were cherry picked instead of merged.

@cmonr cmonr closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SeppoTakalo @0xc0170 @ciarmcom @deepikabhavnani @cmonr