ESP8266: graceful disconnect on network state timeout #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
requested review from
michalpasztamobica,
SeppoTakalo,
Timjun01 and
a team
|
@VeijoPesonen, thank you for your changes. |
SeppoTakalo
approved these changes
Feb 28, 2019
michalpasztamobica
approved these changes
Feb 28, 2019
|
@0xc0170 Fixes internal issue: ONME-4198 (CRITICAL). Maybe release-version: 5.12.0-rc1 instead? |
|
OK , release label moved back |
cmonr
approved these changes
Feb 28, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Wi-Fi connection state change if timeout occurs we have called MBED_ERROR. This seems to happen more often than expected so controlled disconnect works better. Re-establishing the connection is left on application's responsibility.
Fixes internal issue: ONME-4198 (CRITICAL)
Pull request type
Reviewers
@Timjun01
@michalpasztamobica
@SeppoTakalo
Release Notes