Update PSOC6 postbuild prints #9892
Conversation
|
@orenc17, thank you for your changes. |
| m0hexf = next((f for f in hex_files if os.path.basename(f) == os.path.basename(hexf)), m0hexf) | ||
|
|
||
| if m0hexf: | ||
| toolchain.notify.debug("M0 core image file found: %s." % os.path.basename(m0hexf)) | ||
| toolchain.notify.info("M0 core image file found: %s." % m0hexf) |
There was a problem hiding this comment.
Any particular reason for 'debug' -> 'info'?
There was a problem hiding this comment.
It is critical for the user to know which m0 image is merged with the application
Info always prints the message, debug only in verbose mode
There was a problem hiding this comment.
Sweet. That's what I figured.
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
| @@ -120,13 +120,13 @@ def find_cm0_image(toolchain, resources, elf, hexf, hex_filename): | |||
| from tools.resources import FileType | |||
| hex_files = resources.get_file_paths(FileType.HEX) | |||
| m0hexf = next((f for f in hex_files if os.path.basename(f) == hex_filename), None) | |||
| if toolchain.target.name.endswith('_PSA'): | |||
| if toolchain.target.is_PSA_non_secure_target: | |||
There was a problem hiding this comment.
Making sure before the big green button is pressed.
https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L8043
The only current valid target for this is the FUTURE_SEQUANA_PSA correct? Not FUTURE_SEQUANA_M0_PSA?
There was a problem hiding this comment.
find_cm0_image is only executed for M4 targets (those with hex_filename set in targets.json). Therefore, toolchain.target.name.endswith('_PSA') is true only for FUTURE_SEQUANA_PSA, hence this change is safe.
|
cc @ARMmbed/team-cypress |
Description
Pull request type
Reviewers
Release Notes