Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266: Country code API #9927

Merged
merged 3 commits into from
Mar 27, 2019
Merged

ESP8266: Country code API #9927

merged 3 commits into from
Mar 27, 2019

Conversation

VeijoPesonen
Copy link
Contributor

Description

ESP8266Interface API updated with possibility to configure country code and channels to be used.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@kjbracey-arm
@michalpasztamobica

Release Notes

ESP8266Interface: new API to configure country code and channels to be used.

michalpasztamobica
michalpasztamobica reviewed Mar 4, 2019
View reviewed changes
components/wifi/esp8266-driver/ESP8266/ESP8266.cpp Outdated

bool ESP8266::set_country_code_policy(bool track_ap, const char *country_code, int channel_start, int channels)
{
int _track_ap = track_ap ? 0 : 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] isn't an underscore reserved for private class members?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

michalpasztamobica
michalpasztamobica approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there would be a way to smuggle in a link to the lit of acceptable country codes somewhere in the comment? I checked that the Espressif's documentation does not seem to have it.

@VeijoPesonen
Copy link
Contributor Author

I wonder if there would be a way to smuggle in a link to the lit of acceptable country codes somewhere in the comment? I checked that the Espressif's documentation does not seem to have it.

My thinking is that "ISO 3166-1 Alpha-2 coded country code" is a big enough hint. Of course the documentation doesn't really state that it would be followed. I tried the 3-character codes as the documentation mentioned those. Seems to be that allowing 3-characters is not the same as supporting 3-character codes... 'AUT' isn't the same as 'AT' as it is supposed to. The firmware just seems to chop off the last character.

@ciarmcom
Copy link
Member

ciarmcom commented Mar 4, 2019

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @kjbracey-arm @michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

components/wifi/esp8266-driver/ESP8266/ESP8266.cpp Show resolved Hide resolved
@cmonr
Copy link
Contributor

cmonr commented Mar 5, 2019

@ARMmbed/mbed-os-maintainers Here's a question.

5.12.1 or 5.13-rc1? Is this closer to a target update or feature addition?

@VeijoPesonen VeijoPesonen mentioned this pull request Mar 6, 2019
Closed
@NirSonnenschein
Copy link
Contributor

starting CI

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

@VeijoPesonen : CI has passed , please answer the question by @cmonr above.
@kjbracey-arm would you like to review this before it is merged?

@VeijoPesonen
Copy link
Contributor Author

@cmonr , @NirSonnenschein Lets treat it as a Functionality change, a new API for setting the country code was introduced.

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019
Merge pull request ARMmbed#9927 from VeijoPesonen/esp8266_country_cod…
0e3d6e5 
…e_policy

ESP8266: Country code API
@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

@VeijoPesonen @SeppoTakalo
Fyi. In doing a test of all of the Ready for Merge PRs (cmonr#44), I found that this PR's astyle test did not run properly.

We did recently find that some files were being improperly excluded (#10140 (comment)), and have since fixed the astyle job.

After this is merged (no need to hold merge on this glitch), either y'all or I can create a PR to get the repo back clean.

@cmonr cmonr merged commit 1c23c5b into ARMmbed:master Mar 27, 2019
@VeijoPesonen VeijoPesonen deleted the esp8266_country_code_policy branch September 6, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@VeijoPesonen @ciarmcom @cmonr @NirSonnenschein @mbed-ci @SeppoTakalo @michalpasztamobica