Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: Country code API #9927

Merged
merged 3 commits into from Mar 27, 2019

Conversation

Projects
None yet
7 participants
@VeijoPesonen
Copy link
Contributor

commented Mar 4, 2019

Description

ESP8266Interface API updated with possibility to configure country code and channels to be used.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@kjbracey-arm
@michalpasztamobica

Release Notes

ESP8266Interface: new API to configure country code and channels to be used.

components/wifi/esp8266-driver/ESP8266/ESP8266.cpp Outdated

bool ESP8266::set_country_code_policy(bool track_ap, const char *country_code, int channel_start, int channels)
{
int _track_ap = track_ap ? 0 : 1;

This comment has been minimized.

Copy link
@michalpasztamobica

michalpasztamobica Mar 4, 2019

Contributor

[minor] isn't an underscore reserved for private class members?

This comment has been minimized.

Copy link
@VeijoPesonen

VeijoPesonen Mar 5, 2019

Author Contributor

Fixed

@michalpasztamobica
Copy link
Contributor

left a comment

I wonder if there would be a way to smuggle in a link to the lit of acceptable country codes somewhere in the comment? I checked that the Espressif's documentation does not seem to have it.

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

I wonder if there would be a way to smuggle in a link to the lit of acceptable country codes somewhere in the comment? I checked that the Espressif's documentation does not seem to have it.

My thinking is that "ISO 3166-1 Alpha-2 coded country code" is a big enough hint. Of course the documentation doesn't really state that it would be followed. I tried the 3-character codes as the documentation mentioned those. Seems to be that allowing 3-characters is not the same as supporting 3-character codes... 'AUT' isn't the same as 'AT' as it is supposed to. The firmware just seems to chop off the last character.

@ciarmcom ciarmcom requested review from kjbracey-arm, michalpasztamobica, SeppoTakalo and ARMmbed/mbed-os-maintainers Mar 4, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:esp8266_country_code_policy branch to 50984e5 Mar 5, 2019

@cmonr

cmonr approved these changes Mar 5, 2019

Copy link
Contributor

left a comment

👍

@cmonr cmonr added needs: CI and removed needs: review labels Mar 5, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@ARMmbed/mbed-os-maintainers Here's a question.

5.12.1 or 5.13-rc1? Is this closer to a target update or feature addition?

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

starting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 17, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

@VeijoPesonen : CI has passed , please answer the question by @cmonr above.
@kjbracey-arm would you like to review this before it is merged?

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@cmonr , @NirSonnenschein Lets treat it as a Functionality change, a new API for setting the country code was introduced.

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 18, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@VeijoPesonen @SeppoTakalo
Fyi. In doing a test of all of the Ready for Merge PRs (cmonr#44), I found that this PR's astyle test did not run properly.

We did recently find that some files were being improperly excluded (#10140 (comment)), and have since fixed the astyle job.

After this is merged (no need to hold merge on this glitch), either y'all or I can create a PR to get the repo back clean.

@cmonr cmonr merged commit 1c23c5b into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9280 cycles (-1251 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.