Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for secure partition #9939

Merged
merged 4 commits into from Mar 7, 2019

Conversation

Projects
None yet
@NirSonnenschein
Copy link
Contributor

commented Mar 5, 2019

Description

Fix issues found in secure crypto service by compliance tests and update the default pre-built image for PSOC6.

targeted at 5.12RC2

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@itayzafrir @mikisch81 @avolinski

Release Notes

@NirSonnenschein NirSonnenschein requested review from mikisch81 and removed request for mikisch81 Mar 5, 2019

@mikisch81
Copy link
Contributor

left a comment

Can you also update the README of the prebuilt folder with the command to build the acl tests

Nir Sonnenschein

@ciarmcom ciarmcom requested review from avolinski, itayzafrir, mikisch81 and ARMmbed/mbed-os-maintainers Mar 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@NirSonnenschein, thank you for your changes.
@itayzafrir @mikisch81 @avolinski @ARMmbed/mbed-os-maintainers please review.

@itayzafrir
Copy link
Contributor

left a comment

LGTM

@mikisch81
Copy link
Contributor

left a comment

Can you also update the README of the prebuilt folder with the command to build the acl tests

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

@mikisch81 it is already there, added by @orenc17 before this PR.

@orenc17

orenc17 approved these changes Mar 5, 2019

Copy link
Contributor

left a comment

LGTM

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

CI started for now.

Suspect export issue is still a problem, but that job can be restarted once fixed.

@cmonr cmonr added needs: CI and removed needs: review labels Mar 5, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 5, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

0xc0170 approved these changes Mar 6, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

Restarted exporters

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

CI job restarted: jenkins-ci/exporter

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@ARMmbed/mbed-os-maintainers can you run the exporters again?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@orenc17 Will do in a bit.

Testing with a different PR, but it's possible a complete rebuild might be needed.
Restarting just the exporter job appears to not be working as expected.

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@cmonr If restarting does not work for some reason (and is required for some reason, i.e. the Job has failed due to e.g. instability of some sort and is not still exexuting due to e.g. congestion), you can manually build it with parameters and copy the parameters from the old build.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@alekla01 My typical workflow is to go into the Jenkins UI and click Rebuild instead of using Blue Ocean's Rerun option.

The last issue I saw was here: #9312 (comment)

you can manually build it with parameters and copy the parameters from the old build.
Will keep that in mind next time.

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@cmonr, yes, i know, and it should Be OK, but If it is not OK for some reason, error of some sort, you can build it with parameters (select the Job but no build and it should Be in place of rebuild) instead of rebuilding, it does basically the same thing thing, i don't currently have acceess to the Jenkins, but you should at least check it's not already exexuting before either building or rebuilding, and act accordingly, If it is not executing, you should Be at least able to build it If not rebuild currently for some reason.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

Kk. Will retry this current export job with a manual rerun once it completes.

It appears that it's about to fail again.

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

How so, If it timeouts due to node connection error, instead of license, unless the license issues are back, etc, it'll retry the failed targets automatically. If couse If it fails due to some sort of ci error, it required restarting, and potentially ci fix of some sort. Though, of course If it seems to Be failing, it May require abort/fix/rebuild.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

Finally got a chance to dig into the failures, and now I feel silly for the export-only restarts.

Warning: A3912W: Option 'c' is deprecated.
<built-in>:388:10: fatal error: 'mbed_config.h' file not found
#include "./mbed_config.h"
         ^~~~~~~~~~~~~~~~~
1 error generated.

This PR will need to run through CI again, since master has a fix for this problem, but the merge for this PR in Jenkins does not.

@ARMmbed/mbed-os-maintainers Any reason why anyone else didn't look at the logs? Going to check the other export-only PRs needing restart.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 7, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 63242cf into ARMmbed:master Mar 7, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9173 cycles (-1358 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.