-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for secure partition #9939
Fix for secure partition #9939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the README of the prebuilt folder with the command to build the acl tests
@NirSonnenschein, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the README of the prebuilt folder with the command to build the acl tests
@mikisch81 it is already there, added by @orenc17 before this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI started for now. Suspect export issue is still a problem, but that job can be restarted once fixed. |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
Restarted exporters |
CI job restarted: |
@ARMmbed/mbed-os-maintainers can you run the exporters again? |
@orenc17 Will do in a bit. Testing with a different PR, but it's possible a complete rebuild might be needed. |
@cmonr If restarting does not work for some reason (and is required for some reason, i.e. the Job has failed due to e.g. instability of some sort and is not still exexuting due to e.g. congestion), you can manually build it with parameters and copy the parameters from the old build. |
@alekla01 My typical workflow is to go into the Jenkins UI and click The last issue I saw was here: #9312 (comment)
|
@cmonr, yes, i know, and it should Be OK, but If it is not OK for some reason, error of some sort, you can build it with parameters (select the Job but no build and it should Be in place of rebuild) instead of rebuilding, it does basically the same thing thing, i don't currently have acceess to the Jenkins, but you should at least check it's not already exexuting before either building or rebuilding, and act accordingly, If it is not executing, you should Be at least able to build it If not rebuild currently for some reason. |
Kk. Will retry this current export job with a manual rerun once it completes. It appears that it's about to fail again. |
How so, If it timeouts due to node connection error, instead of license, unless the license issues are back, etc, it'll retry the failed targets automatically. If couse If it fails due to some sort of ci error, it required restarting, and potentially ci fix of some sort. Though, of course If it seems to Be failing, it May require abort/fix/rebuild. |
Finally got a chance to dig into the failures, and now I feel silly for the export-only restarts.
This PR will need to run through CI again, since master has a fix for this problem, but the merge for this PR in Jenkins does not. @ARMmbed/mbed-os-maintainers Any reason why anyone else didn't look at the logs? Going to check the other export-only PRs needing restart. |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Description
Fix issues found in secure crypto service by compliance tests and update the default pre-built image for PSOC6.
targeted at 5.12RC2
Pull request type
Reviewers
@itayzafrir @mikisch81 @avolinski
Release Notes