Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: treats Wi-Fi scan results as out-of-band data; new API to adjusting Wi-Fi scan settings #9955

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
8 participants
@VeijoPesonen
Copy link
Contributor

commented Mar 6, 2019

Description

No reason to wait for 15 seconds for the results if those happen to arrive earlier.

Makes possible to decide between Wi-Fi scan active and passive mode.

Makes possible to adjust for how long a single channel is scanned.

Should address the issue #8609

Pull request type

[ ] Fix
[ ] Refactor
[] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@michalpasztamobica
@SeppoTakalo

Release Notes

ESP8266: new Wi-Fi scan API for active and passive mode. Making channel scan time configurable

@ciarmcom ciarmcom requested review from michalpasztamobica, SeppoTakalo and ARMmbed/mbed-os-maintainers Mar 6, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@cmonr

cmonr approved these changes Mar 6, 2019

cnt++;
if (limit != 0 && cnt >= limit) {
break;
if (_parser.send("AT+CWLAP") && _parser.recv("OK\n")) {

This comment has been minimized.

Copy link
@VeijoPesonen

VeijoPesonen Mar 8, 2019

Author Contributor

This is not correct. Should be
if (!_parser.send("AT+CWLAP") || !_parser.recv("OK\n")) {
instead

This comment has been minimized.

Copy link
@SeppoTakalo

This comment has been minimized.

Copy link
@VeijoPesonen

VeijoPesonen Mar 8, 2019

Author Contributor

Fixed

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:esp8266_wifi_scan_timeout branch from 0462629 to d8e691b Mar 8, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

As this PR didn't get fully checked yet I decided to add more content. @michalpasztamobica, @SeppoTakalo please review the new changes.

@VeijoPesonen VeijoPesonen changed the title ESP8266: treats Wi-Fi scan results as out-of-band data ESP8266: treats Wi-Fi scan results as out-of-band data; API for adjust Wi-Fi scan settings Mar 8, 2019

@VeijoPesonen VeijoPesonen changed the title ESP8266: treats Wi-Fi scan results as out-of-band data; API for adjust Wi-Fi scan settings ESP8266: treats Wi-Fi scan results as out-of-band data; new API to adjusting Wi-Fi scan settings Mar 8, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@cmonr the release label should probably be 5.13.0-rc1 . The original fix wasn't so urgent that it must get to 5.12.1.

VeijoPesonen added some commits Mar 6, 2019

ESP8266: new API for setting Wi-Fi scan active/passive mode
Makes possible to decide between active and passive mode.

Makes possible to adjust for how long a single channel is scanned.

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:esp8266_wifi_scan_timeout branch from 102be8e to e2bd064 Mar 14, 2019

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

[X] Target update

This should be rather functionality change ? I was checking why 5.13 labeled.

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@0xc0170 thanks for pointing that out, switched to Functionality change.

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

starting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 17, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

timeout failures on the mbed-os-ci_cloud-client-test . re-running to verify it is not sporadic

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

I would hold this until 5.12 completes to minimize the functional changes at this release stage.

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#9955 from VeijoPesonen/esp8266_wifi_scan_t…
…imeout

ESP8266: treats Wi-Fi scan results as out-of-band data; new API to adjusting Wi-Fi scan settings

@cmonr cmonr merged commit ecfe0c8 into ARMmbed:master Mar 27, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10292 cycles (+50 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.