Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266: treats Wi-Fi scan results as out-of-band data; new API to adjusting Wi-Fi scan settings #9955

Merged
merged 2 commits into from
Mar 27, 2019
Merged

ESP8266: treats Wi-Fi scan results as out-of-band data; new API to adjusting Wi-Fi scan settings #9955

merged 2 commits into from
Mar 27, 2019

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Mar 6, 2019 •
edited
Loading

Description

No reason to wait for 15 seconds for the results if those happen to arrive earlier.

Makes possible to decide between Wi-Fi scan active and passive mode.

Makes possible to adjust for how long a single channel is scanned.

Should address the issue #8609

Pull request type

[ ] Fix
[ ] Refactor
[] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@michalpasztamobica
@SeppoTakalo

Release Notes

ESP8266: new Wi-Fi scan API for active and passive mode. Making channel scan time configurable

@ciarmcom
Copy link
Member

ciarmcom commented Mar 6, 2019

@VeijoPesonen, thank you for your changes.
@michalpasztamobica @SeppoTakalo @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

VeijoPesonen
VeijoPesonen commented Mar 8, 2019
View reviewed changes
components/wifi/esp8266-driver/ESP8266/ESP8266.cpp Outdated
cnt++;
if (limit != 0 && cnt >= limit) {
break;
if (_parser.send("AT+CWLAP") && _parser.recv("OK\n")) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. Should be
if (!_parser.send("AT+CWLAP") || !_parser.recv("OK\n")) {
instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://en.wikipedia.org/wiki/De_Morgan%27s_laws

!(A && B) == !A || !B

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@VeijoPesonen
Copy link
Contributor Author

As this PR didn't get fully checked yet I decided to add more content. @michalpasztamobica, @SeppoTakalo please review the new changes.

@VeijoPesonen VeijoPesonen changed the title ESP8266: treats Wi-Fi scan results as out-of-band data ESP8266: treats Wi-Fi scan results as out-of-band data; API for adjust Wi-Fi scan settings Mar 8, 2019
@VeijoPesonen VeijoPesonen changed the title ESP8266: treats Wi-Fi scan results as out-of-band data; API for adjust Wi-Fi scan settings ESP8266: treats Wi-Fi scan results as out-of-band data; new API to adjusting Wi-Fi scan settings Mar 8, 2019
@VeijoPesonen
Copy link
Contributor Author

@cmonr the release label should probably be 5.13.0-rc1 . The original fix wasn't so urgent that it must get to 5.12.1.

Veijo Pesonen added 2 commits March 14, 2019 12:00
ESP8266: Wi-Fi scan results as OOB
b5f3fcf
ESP8266: new API for setting Wi-Fi scan active/passive mode
e2bd064 
Makes possible to decide between active and passive mode.

Makes possible to adjust for how long a single channel is scanned.
@VeijoPesonen
Copy link
Contributor Author

@SeppoTakalo , @michalpasztamobica , @cmonr rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019 •
edited
Loading

[X] Target update

This should be rather functionality change ? I was checking why 5.13 labeled.

@VeijoPesonen
Copy link
Contributor Author

@0xc0170 thanks for pointing that out, switched to Functionality change.

@NirSonnenschein
Copy link
Contributor

starting CI

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@NirSonnenschein
Copy link
Contributor

timeout failures on the mbed-os-ci_cloud-client-test . re-running to verify it is not sporadic

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 18, 2019

I would hold this until 5.12 completes to minimize the functional changes at this release stage.

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019
Merge pull request ARMmbed#9955 from VeijoPesonen/esp8266_wifi_scan_t…
2d2fb26 
…imeout

ESP8266: treats Wi-Fi scan results as out-of-band data; new API to adjusting Wi-Fi scan settings
@cmonr cmonr merged commit ecfe0c8 into ARMmbed:master Mar 27, 2019
@VeijoPesonen VeijoPesonen deleted the esp8266_wifi_scan_timeout branch September 6, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@VeijoPesonen @ciarmcom @0xc0170 @NirSonnenschein @mbed-ci @cmonr @SeppoTakalo @michalpasztamobica