Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellular: BC95 memory leak fix #9972

Merged
merged 1 commit into from Mar 15, 2019
Merged

cellular: BC95 memory leak fix #9972

merged 1 commit into from Mar 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2019

Description

This fixes a BC95 memory leak, and provides also fix for #9703. Tested with unit tests

Pull request type

[ X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kivaisan @NeilMacMullen

@NeilMacMullen
Copy link
Contributor

Agree this fixes #9703 . Good catch on the memory leak!

@ciarmcom ciarmcom requested review from kivaisan and a team March 7, 2019 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 7, 2019

@TeemuKultala, thank you for your changes.
@kivaisan @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

kivaisan
kivaisan suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@kivaisan kivaisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix delete also in error case (line 193).

@janjongboom
Copy link
Contributor

cppcheck actually finds this error. We should maybe use it more.

@0xc0170 0xc0170 mentioned this pull request Mar 14, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

No more changes are expected there.

This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit 71a1ed9 into ARMmbed:master Mar 15, 2019
@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019
@ghost ghost deleted the cellular_BC95_leak_fix branch May 13, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.12.1 rollup PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NeilMacMullen @ciarmcom @janjongboom @0xc0170 @AnttiKauppila @kivaisan @jarvte