Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OdinWifiInterface is calling memcpy with a null pointer #9986

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@janjongboom
Copy link
Contributor

commented Mar 7, 2019

Description

memcpy is called with source address 0. I think this should be memset not memcpy based on how the function is used.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from screamerbg and ARMmbed/mbed-os-maintainers Mar 7, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@janjongboom, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from ARMmbed/team-ublox Mar 8, 2019

@AmmadRehmat

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@0xc0170 correctly fixed, thank you for making the correction.

@0xc0170

0xc0170 approved these changes Mar 8, 2019

@janjongboom

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@AmmadRehmat Thanks for the quick review!

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

No more changes are expected there.

This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit f3614ab into ARMmbed:master Mar 15, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9165 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.