OdinWifiInterface is calling memcpy with a null pointer #9986

janjongboom · 2019-03-07T15:48:39Z

memcpy is called with source address 0. I think this should be memset not memcpy based on how the function is used.

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

ciarmcom · 2019-03-07T16:00:43Z

@janjongboom, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

AmmadRehmatCUS · 2019-03-08T10:20:45Z

@0xc0170 correctly fixed, thank you for making the correction.

janjongboom · 2019-03-08T10:52:24Z

@AmmadRehmat Thanks for the quick review!

0xc0170 · 2019-03-15T08:51:11Z

No more changes are expected there.

This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately.

OdinWifiInterface is calling memcpy with a null pointer

f3614ab

ciarmcom requested review from screamerbg and a team March 7, 2019 16:00

ciarmcom added the needs: review label Mar 7, 2019

0xc0170 requested a review from a team March 8, 2019 10:13

0xc0170 approved these changes Mar 8, 2019

View reviewed changes

0xc0170 added needs: CI release-version: 5.12.1 and removed needs: review labels Mar 8, 2019

0xc0170 added the rollup PR label Mar 15, 2019

0xc0170 mentioned this pull request Mar 15, 2019

Rollup pt2: fixes for 5.12.1 #10116

Merged

0xc0170 merged commit f3614ab into ARMmbed:master Mar 15, 2019

0xc0170 removed the needs: CI label Mar 15, 2019

Provide feedback