Add some mbed-os dependencies as our own #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 94 94
Lines 2605 2605
=======================================
Hits 2515 2515
Misses 90 90 |
Patater
force-pushed
the
dev/Patater/install-mbed-os-deps
branch
2 times, most recently
from
fcca36e
to
061bc41
Compare
rwalton-arm
reviewed
Jan 26, 2021
Patater
force-pushed
the
dev/Patater/install-mbed-os-deps
branch
5 times, most recently
from
d3c251d
to
13e1858
Compare
rwalton-arm
reviewed
Jan 26, 2021
The SPDX report generator tends not to be sophisticated enough to understand the licenses of even common Python dependencies like setuptools. If we'd like to restore the ability to generate such reports in the future, we should consider one of the many pre-existing tools available to generate such reports for us, rather than develop and maintain our own from scratch.
Add future, prettytable, and intelhex, as required by Mbed OS 6.7, as dependencies to avoid new installs from being complicated by the fact that one must go into mbed-os to install requirements.txt. Yes, these aren't real requirements of mbed-tools. Yes, this is a bit of an architecture violation. However, until we can address the problem in a more suitable way, this should help avoid a common usability impediment. Without this change, the user experience is really not nice, as the build will progress fine until the very last minute (maybe 8 minutes later or so) afterwhich you get some opaque error message about a python library not being found and no clue what to do next. This usability hack should be removed once we have a more appropriate solution ready. This "should" is tracked in #171.
Update our development status to beta, to match what's in our README.md.
List Python 3.9 support explicitly, as we now test with this.
Use Python 3.9 for running tests on Travis.
Patater
force-pushed
the
dev/Patater/install-mbed-os-deps
branch
from
13e1858
to
f19a542
Compare
rwalton-arm
approved these changes
Jan 26, 2021
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add prettytable and intehex as installation dependencies to avoid new
installs from being complicated by the fact that one must go into
mbed-os to install requirements.txt. Yes, these aren't real requirements
of mbed-tools. Yes, this is a bit of an architecture violation. However,
until we can address the problem in a more suitable way, this should
help avoid a common usability impediment.
Test Coverage