PSA Multipart AEAD CCM Internal implementation and tests. #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Encrypt / Decrypt with expected result. Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Known failures, concentrating on verify (bad signature etc.) Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
paul-elliott-arm
added
Arm Contribution
component-psa
mstarzyk-mobica
previously requested changes
Oct 22, 2021
library/psa_crypto_aead.c
Outdated
| @@ -446,11 +444,22 @@ psa_status_t mbedtls_psa_aead_set_lengths( | |||
| size_t ad_length, | |||
| size_t plaintext_length ) | |||
| { | |||
| /* Nothing here yet, work is currently done in PSA Core, however support | |||
| * for CCM will require this function. */ | |||
|
|
|||
There was a problem hiding this comment.
Redundant empty line
mstarzyk-mobica
removed
the
needs-reviewer
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
|
CI Fail is the previous (and now fixed) ssl issue, unrelated to this. |
2 tasks
This was referenced Nov 22, 2021
mprse
reviewed
Nov 30, 2021
The CI failures are due to unrelated known CI issues (timeout issues in the SSL Tests) - hence the HEAD failing, but the Merge tests generally not. The only way I could potentially resolve this would be to force update the branch, as some fixes have been merged since this PR was made. |
gilles-peskine-arm
added
needs-work
and removed
needs-review
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
mprse
approved these changes
Dec 9, 2021
gilles-peskine-arm
approved these changes
Dec 9, 2021
gilles-peskine-arm
dismissed
mstarzyk-mobica’s stale review
The requested changes have been addressed and approved by @mprse.
gilles-peskine-arm
added
approved
|
The CI failures in pr-head are a known unrelated issue in TLS tests, now resolved. pr-merge passed. So CI is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds CCM to the algorithms supported by PSA multipart AEAD. It adds an internal implementation, and a suite of tests for it.
This completes one of the tasks of #3721, however there may be follow up work with regards to Nonce sizes.
Status
READY
Requires Backporting
No. The changes to the underlying cipher API to support multipart are only on this branch. Multipart AEAD was also not backported.
Migrations
No.
Todos
Steps to test
test_suite_psa_crypto should run clean, and all PSA tests should pass.