Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path vs str b/c gdal #204

Merged
merged 3 commits into from
Jan 6, 2023
Merged

fix path vs str b/c gdal #204

merged 3 commits into from
Jan 6, 2023

Conversation

jhkennedy
Copy link
Contributor

No description provided.

@jhkennedy jhkennedy added bug Something isn't working bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version labels Jan 6, 2023
@jhkennedy jhkennedy requested a review from a team as a code owner January 6, 2023 20:35
@asjohnston-asf
Copy link
Member

the mock for _apply_filter_function in test_apply_landsat_filtering should have it's return type updated to match the new function signature: https://github.com/ASFHyP3/hyp3-autorift/blob/develop/tests/test_process.py#L364

@jhkennedy
Copy link
Contributor Author

@asjohnston-asf good catch! Updated

asjohnston-asf
asjohnston-asf approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@asjohnston-asf asjohnston-asf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghcr.io/asfhyp3/hyp3-autorift:0.10.4.dev10_g07a1b1e ran to completion on my laptop for the L4 pair

@jhkennedy jhkennedy merged commit ee03a85 into develop Jan 6, 2023
@jhkennedy jhkennedy deleted the str2path branch January 6, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asjohnston-asf asjohnston-asf asjohnston-asf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhkennedy @asjohnston-asf