Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up access key use for open data upload #248

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

forrestfwilliams
Copy link
Contributor

@forrestfwilliams forrestfwilliams commented Mar 20, 2024

In concert with HyP3 PR #2153, this PR adds support for uploading data to the ITS_LIVE open data bucket with access key permissions.

Since hyp3lib's upload_file_to_s3 does not allow you to pass an S3 client as an argument, I had to create a modified version of this function. We could modify hyp3lib's upload_file_to_s3 to accommodate this, but not sure we want to do this when we only have use case.

@forrestfwilliams forrestfwilliams requested a review from a team as a code owner March 20, 2024 15:15
Copy link
Contributor

@cirrusasf cirrusasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@forrestfwilliams forrestfwilliams merged commit 657dce3 into auto_upload_its_live_data_bucket Mar 20, 2024
2 checks passed
@forrestfwilliams forrestfwilliams deleted the access_key branch March 20, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants