Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Checkstyle report is generating for sun_shecks instead of google_checks. #42

Closed
ABHAY0O7 opened this issue Mar 16, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@ABHAY0O7
Copy link
Contributor

Description of the bug
In the pom.xml file of the maven plugin, it is mentioned that google style is adopted for the checkstyle plugin but after running
mvn checkstyle:checkstyle the report generated in checkstyle.html is for sun checks.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '\depclean\depclean-maven-plugin\target\checkstyle-checker.xml'
  2. See line no. 63
  3. Run mvn checkstyle:checkstyle
  4. Go to '\depclean\depclean-maven-plugin\target\site\checkstyle.html'
  5. Open this file with your browser and read the first line.

Expected behavior
The first line you read above should contain google_checks.xml instead of sun_checks.xml and the whole report should show errors of google_checks instead of sun_checks.

Screenshots
image

image

Additional context
It might also happen that the report is correct but the comment which is showing that google_checks are adopted is wrong.

@ABHAY0O7 ABHAY0O7 added the bug Something isn't working label Mar 16, 2021
@cesarsotovalero
Copy link
Collaborator

Hi @ABHAY0O7, thanks for the bug report.
The Chekstyle report was fixed in 2d5e129

Can you make a pull on the last version of the project and confirm that it is fixed?

@yashrajjain726
Copy link

I checked that part, it is fixed.

@cesarsotovalero
Copy link
Collaborator

Great, thanks @yashrajjain726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants