Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement fallback for move and delete conflicts #128

Merged
merged 6 commits into from
May 22, 2020

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented May 21, 2020

Implements a local fallback for move and delete conflicts by performing a line-based merge on the parent whose child list can't be recovered.

Fix #127

@codecov-commenter
Copy link

Codecov Report

Merging #128 into master will increase coverage by 0.90%.
The diff coverage is 81.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     79.31%   80.22%   +0.90%     
- Complexity      433      443      +10     
============================================
  Files            36       36              
  Lines          1576     1623      +47     
  Branches        242      243       +1     
============================================
+ Hits           1250     1302      +52     
  Misses          208      208              
+ Partials        118      113       -5     
Impacted Files Coverage Δ Complexity Δ
...h/spork/spoon/pcsinterpreter/SpoonTreeBuilder.java 87.40% <0.00%> (+2.36%) 41.00 <1.00> (+1.00)
...va/se/kth/spork/spoon/printer/SourceExtractor.java 88.73% <ø> (+2.81%) 29.00 <0.00> (+1.00)
...h/spork/spoon/pcsinterpreter/SporkTreeBuilder.java 82.20% <75.00%> (-4.32%) 30.00 <3.00> (+3.00) ⬇️
...in/java/se/kth/spork/spoon/StructuralConflict.java 85.29% <90.00%> (+1.29%) 16.00 <1.00> (+1.00)
...kth/spork/spoon/pcsinterpreter/PcsInterpreter.java 85.71% <100.00%> (ø) 1.00 <1.00> (ø)
...se/kth/spork/spoon/printer/SporkPrettyPrinter.java 88.32% <100.00%> (+4.98%) 23.00 <2.00> (+2.00)
...rc/main/java/se/kth/spork/util/LineBasedMerge.java 82.05% <100.00%> (+4.90%) 7.00 <1.00> (+1.00)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eaaa9f...ad94ef9. Read the comment docs.

@slarse slarse merged commit 02ad893 into master May 22, 2020
@slarse slarse deleted the issue/127-handle-move-and-delete-conflicts branch February 18, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express move and delete conflicts (roughly)
2 participants