Better handle WebExceptions that don't have a Response and send a cus…

…tomized exception on WebExceptionStatus.SendFailure errors (usually from TLS errors). Fixes opentok#108.
ATLCTO · Oct 6, 2018 · 822613c · fidergo-stephane-gourichon · May 3, 2019 · fidergo-stephane-gourichon
1 parent f9907ea
commit 822613c
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/OpenTok/Util/HttpClient.cs b/OpenTok/Util/HttpClient.cs
@@ -116,17 +116,24 @@ public virtual string Delete(string url, Dictionary<string, string> headers, Dic
 
                 response = (HttpWebResponse)e.Response;
 
-                DebugLog("Response Status Code: " + response.StatusCode);
-                DebugLog("Response Status Description: " + response.StatusDescription);
-                DebugLogHeaders(response.Headers, "Response");
-
-                if (this.debug)
+                if (response != null)
                 {
-                    using (var stream = new StreamReader(response.GetResponseStream()))
+                    DebugLog("Response Status Code: " + response.StatusCode);
+                    DebugLog("Response Status Description: " + response.StatusDescription);
+                    DebugLogHeaders(response.Headers, "Response");
+
+                    if (this.debug)
                     {
-                        DebugLog("Response Body: " + stream.ReadToEnd());
+                        using (var stream = new StreamReader(response.GetResponseStream()))
+                        {
+                            DebugLog("Response Body: " + stream.ReadToEnd());
+                        }
                     }
                 }
+                else if (e.Status == WebExceptionStatus.SendFailure)
+                {
+                    throw new OpenTokWebException("Error with request submission (TLS1.1 or other network/protocol issue)", e);
+                }
 
                 throw new OpenTokWebException("Error with request submission", e);
             }