New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when parsing Java version #262
Comments
According to the post, this was an issue because we don't support Java 9 (as it's unreleased). Is this still a bug then? |
@flaw600 @RyanTheAllmighty Just FYI, I have a local copy of the repo with improved code for the Java version parsing, which should be more future-proof (it basically matches the first valid integer and ignores the leading @RyanTheAllmighty Don't want to pressure you or anything, but could you quickly look over #267? Then I could make a new PR with the Java version fixes. |
@dgelessus if you push to the branch that will be merged from in your PR, then whenever @RyanTheAllmighty accepts the PR it should take whatever changes are in that branch at merge time, so you shouldn't have to submit a new PR. That said, I don't remember if I already fixed the parsing problem (I have a vague memory of doing so earlier with a similar method to yours) but I don't recall exactly so could you confirm that this hasn't already been fixed in the official repo? Thanks! |
Alright, PR has been submitted: #269 |
Should this be closed now that the PR is merged? @RyanTheAllmighty |
@dgelessus sorry to be a pain but can you backport this to 3.2.3.2 as I don't see 3.3.0.0 ever seeing the light of day |
@RyanTheAllmighty I don't have a PC for the next few weeks, sorry. Will have a look when I can though. |
Released |
As per the post at https://forums.atlauncher.com/thread-13000.html there seems to be an issue parsing some Java verisons:
The text was updated successfully, but these errors were encountered: