Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skin preview displays wrongly on accounts page for 1.8+ skins #379

Closed
lenaclariel opened this issue Dec 9, 2019 · 2 comments
Closed

Skin preview displays wrongly on accounts page for 1.8+ skins #379

lenaclariel opened this issue Dec 9, 2019 · 2 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@lenaclariel
Copy link

Describe the bug
The skin shown on the accounts tab when using a 1.8+ skin does not display properly, displaying similarly to when a 1.8+ skin is used in Minecraft 1.7.10 i.e. with both arms and both legs the same.

To Reproduce
Steps to reproduce the behavior:

  1. Upload an asymmetric 1.8+ version skin (i.e. one with different content for left and right arms, or left and right legs) to an account.
  2. Log in to account in ATLauncher and switch to it.
  3. Go to accounts tab.

Expected behavior
Skin preview displays properly, with different arms and different legs based on the skin.

Screenshots
Screenshot from 2019-12-09 15-01-54

Desktop:

  • OS: Ubuntu 18.04.3 LTS
  • Version: ATLauncher 3.3.1.4

Additional context
The issue is with the skin preview construction in com.atlauncher.data.Account.getMinecraftSkin(), I believe.
@lenaclariel lenaclariel added the bug Confirmed bugs or reports that are very likely to be bugs. label Dec 9, 2019
RyanTheAllmighty added a commit that referenced this issue Jun 26, 2020
@RyanTheAllmighty
fix: [#379] newer 1.8 skins not showing different arms correctly
c7ba50a
@RyanTheAllmighty
Copy link
Member

Will be released with version 3.3.5.3 of the launcher likely on the 2nd of July due to some caching issues the launcher had.

@RyanTheAllmighty
Copy link
Member

Released with version 3.4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RyanTheAllmighty @lenaclariel