-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher doesn't work with ARM devices #390
Comments
Not as simple as that. Apparently it's not simple to compile arm binaries on linux. Progress moved to issue-390 branch |
New binary created which also gets more information including CPU count and GPU information which is logged to the console. Safeguards are also in place to make sure in the case where the binary doesn't exist, fails to be called, or in the case of what we had here, architectures not being supported, the launcher will continue on and log a warning out to the console. This only adds in binaries for Linux arm and arm64, Windows and OSX couldn't be built, but given arm based macs are going to be the new normal soon, this will need to be investigated whenever I get access to one (if ever) |
The new getSystemInfo is triggering a bunch of antivirus and malware programs. In order to not delay the release, I think we'll need to drop the arm support that was added in. While the launcher should be fine with ARM, it'll not be able to get the memory in the system due to the virus issue. |
I think oshi is the solution to our problems with this. Seems to be a JNA based way to get system information. |
Released with version 3.4.0.0 |
The getMemory tool we use doesn't support arm, so people using arm architectures cannot start the launcher.
Go supports building for it, so should be easy enough to fix.
https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63#a-list-of-valid-goarch-values
Just means we need to build for arm and arm64 for all OS doubling the number of artifacts
The text was updated successfully, but these errors were encountered: