Checking for pack updates on Modrinth without a project id causes errors

[RyanTheAllmighty]

What happened?

When the updater checks for pack updates to Modrinth instances, if there is a missing project ID for some reason, it still attempts to do the call, which will just error out.

We should not be doing the calls to check for updates if either the project or version id's are missing

Operating System

Windows

Relevant log output

[27/02/2024 19:16:30 p.m.] com.atlauncher.network.DownloadException: https://api.modrinth.com/v2/project//version request wasn't successful: Response{protocol=http/1.1, code=404, message=Not Found, url=https://api.modrinth.com/v2/project//version}
	at com.atlauncher.network.Download.execute(Download.java:334)
	at com.atlauncher.network.Download.asTypeWithThrow(Download.java:179)
	at com.atlauncher.network.Download.asType(Download.java:186)
	at com.atlauncher.network.Download.asType(Download.java:200)
	at com.atlauncher.utils.ModrinthApi.getVersions(ModrinthApi.java:242)
	at com.atlauncher.utils.ModrinthApi.getVersions(ModrinthApi.java:192)
	at com.atlauncher.managers.ModrinthModpackUpdateManager.lambda$checkForUpdates$2(ModrinthModpackUpdateManager.java:91)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Unknown Source)
	at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
	at java.base/java.util.stream.ForEachOps$ForEachTask.compute(Unknown Source)
	at java.base/java.util.concurrent.CountedCompleter.exec(Unknown Source)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(Unknown Source)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.helpComplete(Unknown Source)
	at java.base/java.util.concurrent.ForkJoinPool.helpComplete(Unknown Source)
	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(Unknown Source)
	at java.base/java.util.concurrent.ForkJoinTask.invoke(Unknown Source)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(Unknown Source)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(Unknown Source)
	at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
	at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
	at com.atlauncher.managers.ModrinthModpackUpdateManager.checkForUpdates(ModrinthModpackUpdateManager.java:90)
	at com.atlauncher.Launcher.lambda$checkForExternalPackUpdates$9(Launcher.java:340)
	at java.base/java.lang.Thread.run(Unknown Source)

Additional Information

No response

Is this actually a launcher bug?

• I am sure this is a bug with the launcher and not an issue with running Minecraft

Code of Conduct

• I agree to follow this project's Code of Conduct

[atlauncher-bot]

This has been fixed with version 3.4.35.9