Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing content specific notification methods #5

Open
juho-jaakkola opened this issue Aug 16, 2013 · 8 comments
Open

Allow choosing content specific notification methods #5

juho-jaakkola opened this issue Aug 16, 2013 · 8 comments

Comments

@juho-jaakkola
Copy link
Contributor

It would be cool to allow users decide what notification methods they want to use for each specific content.

The UI Could look something like this:

comment_tracker_popup

Each checkbox could trigger an XHR request. Or there could be a submit bottom at the bottom of the popup.

I wonder if users would like this kind of UI change. Would it just make subscribing more difficult? Opinions?

@beck24
Copy link
Member

beck24 commented Aug 17, 2013

Hmm, I like the idea in theory - but it is at minimum one extra click to subscribe.
If we could make this based on a user and/or admin setting that might be best. Then power users can have their full control over notification methods while average folk can keep a default setting and one-click subscription.
I don't think doing this by default is the best way forward, but it is a nice feature to have.
If going this route XHR would definitely be the way to go, as I've made the rest of the plugin ajaxed.

@juho-jaakkola
Copy link
Contributor Author

I wouldn't want to add a setting for this. It adds complexity and settings are difficult to get rid of later.

I asked peoples opinion at work and so far everyone is in favor of this change. I really don't think users use the subscribe feature that often. So a couple of extra clicks wouldn't be a problem.

I will make a pull request soon so you can also try out the UI. We can decide about the settings later.

And yes, I plan to use XHR. I was just wondering whether there should be a submit button that does the XHR request or if each separate checkbox should trigger its own request.

@beck24
Copy link
Member

beck24 commented Aug 18, 2013

Been giving this some thought, if there's no submit button, they'll still need to click somewhere to close the dialog anyway, and you have potentially multiple XHR requests to update the selections. If we use a submit button all selections can be sent as a single XHR request and the submit action can trigger the closing of the dialog.

@juho-jaakkola
Copy link
Contributor Author

Good point about having to close the popup anyway.

@juho-jaakkola
Copy link
Contributor Author

Hm... why not use both? Let's have a link that subscribes using default notification settings - no questions asked. And another menu item (small symbol for dropdown menu) that opens the form with content-specific notification settings.

@beck24
Copy link
Member

beck24 commented Aug 22, 2013

That sounds good to me, only downside is entity menu congestion, but site owners have to deal with that anyway. Also that make it easier to force one or the other method if the site owner wants a specific UX

@juho-jaakkola
Copy link
Contributor Author

I think I'll finish the 1.9 update without this feature.

@beck24
Copy link
Member

beck24 commented Oct 23, 2015

Revisiting this - I like the idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants