Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to JuliaCall from PyJulia #86

Merged
merged 34 commits into from
Feb 12, 2024
Merged

Migrate to JuliaCall from PyJulia #86

merged 34 commits into from
Feb 12, 2024

Conversation

ma-sadeghi
Copy link
Collaborator

@ma-sadeghi ma-sadeghi commented Feb 9, 2024 •
edited
Loading

PyJulia has caused so much trouble and pain. Fixes #13

@ma-sadeghi ma-sadeghi added the enhancement New feature or request label Feb 9, 2024
@ma-sadeghi
Ensure unit tests find valid GEPs (used to pass even when no circuit …
54b9fdb 
…was found)
@ma-sadeghi
Raise ImportError instead of assert when Julia/backend not found
1d862c2
@ma-sadeghi
Fix pep8, minor refactor
223532b
@ma-sadeghi
Refactor parse_ec_output to accept list[str] instead of dataframe
5776f83
@ma-sadeghi
Fix typo
8d59639
@ma-sadeghi
Fix docstrings
75f018f
@ma-sadeghi
Minor refactor: replace Main with jl, import once at module level
8f968bd
@ma-sadeghi
Convert EquivalentCircuits output parser to dataframe
636ad6e
@ma-sadeghi
Circuit generator wrappers should all return list[str], EquivalentCir…
00d69ba 
…cuits parser takes care of conversion
@ma-sadeghi
Lower number of GEP generations in unit tests for speed
2165db8
@ma-sadeghi
Use my patched up fork until EquivalentCircuits is patched
37ad1d0
@ma-sadeghi
Avoid importing package during cli ops
f2cc4c9
@ma-sadeghi
Fix pep8
cd8eac6
@ma-sadeghi
Avoid importing autoeis when not needed
0bd636e
@ma-sadeghi
Guard against missing Julia deps
085b069
@ma-sadeghi
Fix bug in Julia package import
23fe411
@ma-sadeghi
Automatically install Julia and dependencies if not found
6e037c9
@ma-sadeghi
Use juliapkg to locate Julia
c5fd3c1
@ma-sadeghi
Locate Julia more robustly
6877041
@ma-sadeghi
Contain Julia deps installations from julia helpers
10e398a
@ma-sadeghi
Try different juliapkg API to see if Julia has been already installed
84bdd75
@ma-sadeghi
Add a more powerful system-level output suppressor to suppress Julia …
87387f5 
…installation log
@ma-sadeghi
init_julia should throw error if Julia is not found
2adfa0a
@ma-sadeghi
import_backend shouldn't install backend by default if not found
d8b4b46
@ma-sadeghi ma-sadeghi merged commit 683873a into develop Feb 12, 2024
6 checks passed
@ma-sadeghi ma-sadeghi deleted the enh/julia-backend branch February 12, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore replacing pyjulia with PythonCall.jl for better compatiblity with conda
1 participant
@ma-sadeghi