-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stable-diffusion-webui-wd14-tagger.json #120
Conversation
Credits for Toriato for his work, but his extension has been inactive, with some issues. I had a pull request for a while, and it has been growing, to the extent that some suggested me to just create a main branch and present it here. See my last reease notes here: https://github.com/picobyte/stable-diffusion-webui-wd14-tagger/releases And the discussion: toriato/stable-diffusion-webui-wd14-tagger#93
e72743a
to
e55ab9d
Compare
ty @picobyte ! |
let me resolve the conflict when the time comes |
sure, whenever you're ready |
should we reset added date? |
Its weird because it will end up at the top with increased visibility. We should keep the legacy order or else people will wrongly view the new extension by stars. I can try to find the original submission data's of forked extensions and put them back with a PR |
the current automation is such that the origin date will be kept and internal order of the extension index will be kept the added date will be filled with the current date if the date is missing (this is what happens to new entries) new extensions will be added at the bottom AUTOMATIC1111/stable-diffusion-webui#11520
|
So if their is a new maintainer, everyone will see by default in "internal order" mode. Internal order has been messed up by me when I tried "grouping" extensions close to each other by common theme.
|
there are 3 time commit_time the commit time of the default branch of the repo, can be seens as the update time |
We keep the "images browser" extension legacy added date at 2022, despite the fork. The forks creation is 2023. We should probably keep everything like images browser, we can fix the improper dates set manually. |
you can set the date manually |
I don't think so.
|
sure if you think of necessary, I have no strong objections
if you want to modify the date you can edit the entries in the exchange directory, don't change it in index,json on the other hand if you wish to modify the order of the extensions in the index.json, then edit the index directly the order of index.json doesn't change upon build and metadata update another way of phrasing it is that
these are 2 extensions that I remember have uodate the added date when updating URL |
fyi there is one extension: sd-webui-color-enhance |
I was the one who approved that extension |
Thank you for the responsibility. I must say I didn't fully understand what the replies were about, I'm guessing you were just discussing extension intrinsics; comments that were not for me, but if there is anything I still need to do or change, let me know or just point out which comment was relevant. I've enabled issue tracker discussion and wiki on my fork of the tagger project. |
ahhh they run down is that we were going to wait for around a week before changing to your fork, but then the original offer replied so I just merge the change immediately |
Credits for Toriato for his work, but his extension has been inactive, with some issues. I had a pull request for a while, and it has been growing, to the extent that some suggested me to just create a main branch and present it here. See my last reease notes here for the updated changes list:
https://github.com/picobyte/stable-diffusion-webui-wd14-tagger/releases
And a prior discussion:
toriato/stable-diffusion-webui-wd14-tagger#93
I am hospitalized for a few days, so I may not be able to respond in a few days - patch/fix for a cycling tourist collision, handling a mobile phone