Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable-diffusion-webui-wd14-tagger.json #120

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

picobyte
Copy link
Contributor

@picobyte picobyte commented Jul 9, 2023

Credits for Toriato for his work, but his extension has been inactive, with some issues. I had a pull request for a while, and it has been growing, to the extent that some suggested me to just create a main branch and present it here. See my last reease notes here for the updated changes list:
https://github.com/picobyte/stable-diffusion-webui-wd14-tagger/releases

And a prior discussion:
toriato/stable-diffusion-webui-wd14-tagger#93

I am hospitalized for a few days, so I may not be able to respond in a few days - patch/fix for a cycling tourist collision, handling a mobile phone

AUTOMATIC1111 and others added 2 commits July 9, 2023 05:30
Credits for Toriato for his work, but his extension has been inactive, with some issues. I had a pull request for a while, and it has been growing, to the extent that some suggested me to just create a main branch and present it here.
See my last reease notes here:
https://github.com/picobyte/stable-diffusion-webui-wd14-tagger/releases

And the discussion:
toriato/stable-diffusion-webui-wd14-tagger#93
@ClashSAN
Copy link
Collaborator

ty @picobyte !
We add this in 1 week since toriato doesnt have github activity in 4 months.

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 10, 2023

let me resolve the conflict when the time comes
the conflict is due to git not able to cope with the vast amount of changes done to the index because the introduction of metadata metadata to the index
this should not happen again after subsequent for commits

@ClashSAN
Copy link
Collaborator

sure, whenever you're ready

@w-e-w w-e-w merged commit 87328b7 into AUTOMATIC1111:master Jul 10, 2023
1 check passed
@w-e-w
Copy link
Collaborator

w-e-w commented Jul 10, 2023

should we reset added date?

@ClashSAN
Copy link
Collaborator

Its weird because it will end up at the top with increased visibility. We should keep the legacy order or else people will wrongly view the new extension by stars.

I can try to find the original submission data's of forked extensions and put them back with a PR

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 11, 2023

the current automation is such that the origin date will be kept and internal order of the extension index will be kept

the added date will be filled with the current date if the date is missing (this is what happens to new entries)

new extensions will be added at the bottom
the identifier is based on the URL
so if a extension has a change of URL it will be moved to the bottom of the list

AUTOMATIC1111/stable-diffusion-webui#11520
it's currently sortable by these fields

newest first
oldest first
a-z
z-a
internal order
update time
create time
stars

@ClashSAN
Copy link
Collaborator

ClashSAN commented Jul 11, 2023

So if their is a new maintainer, everyone will see by default in "internal order" mode.

Internal order has been messed up by me when I tried "grouping" extensions close to each other by common theme.

  • Then, other people add theirs on the top, the middle and the bottom..

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 11, 2023

there are 3 time
added time the time that it's been added to the index, this is a local value that we set

commit_time the commit time of the default branch of the repo, can be seens as the update time
created_at the create time of the repo, IMO this value is not too useful, but vlad think it is in some usecase, so I included
these 2 values are from github's api

@ClashSAN
Copy link
Collaborator

We keep the "images browser" extension legacy added date at 2022, despite the fork. The forks creation is 2023.

We should probably keep everything like images browser, we can fix the improper dates set manually.

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 11, 2023

you can set the date manually
it only auto fills the added date when the date is invladi / not found
or are you talking about the 2 other dates?

@ClashSAN
Copy link
Collaborator

ClashSAN commented Jul 11, 2023

should we reset added date?

I don't think so.

  • It is preferable that people submitting do not change the date
  • It is important to me to keep the primary (non-fork's) date: (the "added" section)
    • some replacement forks changed the date, we can change it back manually.

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 11, 2023

I don't think so.

  • It is preferable that people submitting do not change the date

  • It is important to me to keep the primary (non-fork's) date: (the "added" section)

    • some replacement forks changed the date, we can change it back manually.

sure if you think of necessary, I have no strong objections
the only thing that I was considering was that maybe moving it up the list and people might notice and change to the fort so that they can receive new updates

hmm maybe we can possibly build this in to webui

if you want to modify the date you can edit the entries in the exchange directory, don't change it in index,json

on the other hand if you wish to modify the order of the extensions in the index.json, then edit the index directly

the order of index.json doesn't change upon build and metadata update

another way of phrasing it is that

  • existing extensions on the index of updated from extensions directory
  • new extensions are added at the bottom
  • the URL is used as the ID

these are 2 extensions that I remember have uodate the added date when updating URL
#94
#79

@ClashSAN
Copy link
Collaborator

ClashSAN commented Jul 11, 2023

@w-e-w

fyi there is one extension: sd-webui-color-enhance
that is outside github. It will have no metadata, I don't know if people adding an extension from gitlab will affect automations.

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 11, 2023

I was the one who approved that extension
I built the metadata action to skip non GitHub repos

@picobyte
Copy link
Contributor Author

Thank you for the responsibility. I must say I didn't fully understand what the replies were about, I'm guessing you were just discussing extension intrinsics; comments that were not for me, but if there is anything I still need to do or change, let me know or just point out which comment was relevant. I've enabled issue tracker discussion and wiki on my fork of the tagger project.

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 11, 2023

ahhh
actually pretty much none of the conversation pertains to you
we're just using this place as discussion for something else

they run down is that we were going to wait for around a week before changing to your fork, but then the original offer replied so I just merge the change immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants