-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: (Optimization) Option to remove negative conditioning at low sigma values #9129
Comments
Nice work! Live preview image seems to be working fine for me with this. Do you mean by it being broken it's behaving in a way it shouldn't? Regardless it seems worth it to at least open a draft PR for this. Auto does not read issues and this would otherwise go unnoticed until a PR is made. |
PR made: #9177 |
also fixed the live previews |
Seems to work nicely, but what numeric type is meant to be supported?
|
A big bug: 我测试了一下,把这个值设置为小数,会给WebUi带来一些问题。 比如设置为0.7,那么“生成”按钮下的那几个图标功能会失效,并在命令行提示错误。但是如何设置为整数,比如'1"那就正常了。 Traceback (most recent call last): |
Is there an existing issue for this?
What would your feature do ?
At low sigma values towards the latter steps of a diffusion process, there is not much practical difference between different cfg values. Setting cfg=1 for these steps allows the calls to the unet to be cut in half with minimal quality loss.
Original: https://twitter.com/Birchlabs/status/1640033271512702977
with high-res fix on, and step counts ~20-30 the difference is even less noticable:
Proposed workflow
settings/Sampler parameters
(or perhaps a more suitable setting menu)Negative Guidance minimum sigma
Additional information
From experimentation, values below 0.8 preserve quality decently unless the step count is too high. With hi-res fix on, values up to 0.95 can work fairly well.
I have a version of this that does function, but it breaks live image preview:
master...devNegative-asm:stable-diffusion-webui:master
The text was updated successfully, but these errors were encountered: