Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo and list of the features to README.md #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vrozin
Copy link

@vrozin vrozin commented Mar 1, 2019

Description of the Change

  1. Added AVMf logo to README.md file at the top of the page. Centered.
  2. Added key features from here (the work is dated by October 2016).

Alternate Designs

The logo can be relocated/resized.
The list can be modified.

Benefits

Possible users of the framework will be able to see what the framework can be used for.

Possible Drawbacks

N/A

Applicable issues

Fixes #17

Add key features list
Copy link
Collaborator

@enpuyou enpuyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vrozin, thank you so much for working on this issue. The content looks good! I apologize for not reviewing this PR sooner. We have been setting up the Travis CI with style guides check and lint tools for the project. With that said, can you please update your branch to the fix-readme branch, which now passes the build. And once your branch passes the Travis CI build, we will be able to merge in your PR. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improper/insufficient information given
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants