Fix ScreenRecorder#stop return value

AXElements · Dec 9, 2012 · ae117d0 · ae117d0
1 parent 69e253f
commit ae117d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/History.markdown b/History.markdown
@@ -1,3 +1,7 @@
+# 0.1.1 - Derp Release
+
+  * Fixed `ScreenRecorder#stop` return value
+
 # 0.1.0 - Initial Release
 
   * CRuby and MacRuby compatible

diff --git a/ext/screen_recorder/MCScreenRecorder.m b/ext/screen_recorder/MCScreenRecorder.m
@@ -104,7 +104,7 @@ - (BOOL) stop
   [self.session stopRunning];
   [self.output stopRecording];
 
-  if (!dispatch_semaphore_wait(self.sema, SEMA_WAIT_TIME))
+  if (dispatch_semaphore_wait(self.sema, SEMA_WAIT_TIME))
     return NO;
 
   // need to wait for some callbacks because we want synchronousness
@@ -113,9 +113,11 @@ - (BOOL) stop
     case kCFRunLoopRunStopped:
       break;
     case kCFRunLoopRunTimedOut:
-      return NO; // 'did not get callback'
+      NSLog(@"Did not get callback");
+      return NO;
     default:
-      return NO; // 'unexpected result from waiting for callback'
+      NSLog(@"Unexpected result from waiting for callback");
+      return NO;
     }
 
   if (dispatch_semaphore_wait(self.sema, SEMA_WAIT_TIME))