-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change getInterviewSlot method and add isScheduled status #150
Conversation
@@ -108,7 +108,7 @@ private CommandResult executeTimeslotCommand(Model model) throws CommandExceptio | |||
throw new CommandException(MESSAGE_INVALID_PERSON_NAME); | |||
} | |||
|
|||
if (model.getInterviewSlots(toEmail.getName().toString()).size() == 0) { | |||
if (model.getInterviewSlot(toEmail.getName().toString()) == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use Optional.isEmpty()
@@ -137,7 +137,7 @@ private CommandResult executeAllTimeslotsCommand(Model model) throws CommandExce | |||
int sent = 0; | |||
|
|||
for (Interviewee interviewee : intervieweeList) { | |||
if (model.getInterviewSlots(interviewee.getName().toString()).size() == 0) { | |||
if (model.getInterviewSlot(interviewee.getName().toString()) == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use Optional.isEmpty()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
No description provided.