Add test case and fix deficiency #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirozo
reviewed
Nov 7, 2019
| @@ -0,0 +1,3 @@ | |||
| Full Name,NUS Email Address,Personal Email Address,Mobile Number,Faculty/School,Year of Study,Choice of Deparment,Time slots | |||
| John Doe,john@u.nus.edu,john@hotmail.com,99999999,NUS,1,Department A,"09/10/2019 18:30-19:00, 10/10/2019 19:00-19:30, 11/10/2019 20:00-20:30" | |||
| John Toh,john@u.nus.edu,john@hotmail.com,99999999,NUS,1,Department B,"09/10/2019 18:30-19:00, 10/10/2019 19:00-19:30, 11/10/2019 20:00-20:30" | |||
There was a problem hiding this comment.
Failed checkstyle: error - prohibited \r\n line ending, use \n instead.
mirozo
reviewed
Nov 7, 2019
| return schedulesList; | ||
| } | ||
|
|
||
| @Override | ||
| public List<List<String>> getTitlesLists() { | ||
| Collections.sort(schedulesList); | ||
| List<List<String>> titlesLists = new LinkedList<>(); | ||
| for (Schedule schedule : schedulesList) { |
There was a problem hiding this comment.
Actually can just do Collections.sort once in the setSchedules() method, instead of 3 times over here.
mirozo
reviewed
Nov 7, 2019
| } | ||
|
|
||
| // ========================================= Helper methods ================================================= | ||
| /** |
There was a problem hiding this comment.
Is it better to leave helper methods in the CommandTestUtil class? Theres a section for convenience methods in the class.
mirozo
approved these changes
Nov 7, 2019
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.