Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and more abstraction #179

Merged

Conversation

KendrickAng
Copy link
Member

Fixed a bug where duplicate slots/departments were accepted as valid input when a user adds or edits an interviewee/interviewer. Also abstracted out DeleteCommand into DeleteIntervieweeCommand and DeleteInterviewer Command, with test cases added.

@ChrisKheng ChrisKheng added this to the v1.4 milestone Nov 9, 2019
Copy link
Member

@dcshzj dcshzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dcshzj dcshzj merged commit 344a27d into AY1920S1-CS2103-F09-1:master Nov 9, 2019
@dcshzj dcshzj mentioned this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants