[Complete] Import Interviewer's Data from .csv file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY1920S1-CS2103-F09-1/main: Add add, delete, quickstart to user guide (AY1920S1-CS2103-F09-1#33) Update UserGuide.adoc (AY1920S1-CS2103-F09-1#32) Update site name and github link Update About Us page & Contact Us Page Update README.adoc Update coveralls link in README.adoc Update README.adoc Update README.adoc
ChrisKheng
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Looks good to me! But in future, if got time I think you can make CsvReader return a List<List<List>> (representing the tables) instead and then do the converting to Schedule objects in execute() of ImportCommand instead as I think the code for converting to Schedule objects are more relevant to ImportCommand
25 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing Interviewer's data creates an ArrayList of Schedule objects which I have not stored for the time being.