Skip to content

Commit

Permalink
Fix bugs (#347)
Browse files Browse the repository at this point in the history
* Adds module codes to autocomplete

* Fixes checkstyle

* Adds autocomplete to Dev Guide

* Adds getActiveTags

* Refines dev guide and Autocomplete implementation

* Modifies help

* Modifies help more

* Adds specific help commands

* Edits dev guide to include help

* Fixes checkstyle

* Adds HelpCommandTest

* Adds HelpCommandParserTest

* Adds typical module planner.

* Adds to help

* Adds HelpCommandTest

* Fixes Autocomplete bug, Changes minor ui

* Fixes checkstyle

* Quickfix autocomplete with tags

* Edits User Guide

* Updates Help and Autocomplete

* Adds collapse and expand

* Adds collapse, expand tests

* Adds expand and collapse parser tests

* Adds readability to help

* Removes important from css

* Adds expand and collapse to help

* Adds collapseall expandall, Modifies Current sem implementation

* Removes old current sem

* Fixes codacy

* Allows multiple mods for addmod

* Adds some logging.

* Reconfigures autocomplete

* Adds documentation

* Adds autocomplete testing

* Adds Semester names to autocomplete

* Edits user guide.

* Modifies developer guide for autocomplete

* Removes unused field

* Changes UI in Dev Guide

* Adds different GUI Modes.

* Fixes checkstyle

* Adds tests, changes dark mode

* Removes old dark theme

* Modifies Dark Mode

* Edits tag view

* Rearranges User Guide

* Quickfixes collapse and help

* Refactors mode to theme

* Fixes checkstyle

* First draft of PPP

* Adds PPP

* Edits PPP

* Fixes left display

* Adds Hacker Theme

* Fixes checkstyle

* Fixes viewplan GUI for light theme

* Reverting previous commits

* Revert "Fixes left display"

This reverts commit ce1256a.

* Redoes the changes, but fixed this time

* Edits ResultDisplayHandle

* Beautifies hacker mode

* Adds Dawn theme

* Rename PPP

* Edits userguide

* Bug fixes

* Fixes bugs

* Fixes checkstyle

* Fixes bugs

* Fixes codacy
  • Loading branch information
yaaanch authored and chowyiwai committed Nov 11, 2019
1 parent 79102d6 commit 0c90ed5
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 14 deletions.
3 changes: 2 additions & 1 deletion docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,7 @@ Use case ends.

// end::uc01[]

// tag::uc02[]
=== Use case: UC02 - Add module

*MSS*
Expand All @@ -831,7 +832,7 @@ Use case ends.
Steps 1a1-1a2 are repeated until the data entered are correct.
+
Use case ends.

// end::uc02[]
// tag::uc03[]
=== Use case: UC03 - Commit a study plan

Expand Down
4 changes: 3 additions & 1 deletion docs/team/yaaanch.adoc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
= Ong Yan Chun (yaaanch)- Project Portfolio
= Ong Yan Chun (yaaanch) Project Portfolio
:site-section: AboutUs
:imagesDir: ../images
:stylesDir: ../stylesheets
Expand Down Expand Up @@ -60,6 +60,7 @@ https://github.com/AY1920S1-CS2103-F09-3/main/pull/169[#169])
** Documentation:
*** Edited UI section in Developer Guide.
*** Helped to rearrange sections within User Guide.
*** Wrote user stories and target user profile.
** Community:
*** Reviewed other team's Developer Guide: [https://github.com/nus-cs2103-AY1920S1/addressbook-level3/pull/11/files/a420128b5b5e72e1fb07a6ba7fdfee5f52b4fcdc?file-filters%5B%5D=.adoc&file-filters%5B%5D=.csv&file-filters%5B%5D=.gradle&file-filters%5B%5D=.java&file-filters%5B%5D=.jpg&file-filters%5B%5D=.json&file-filters%5B%5D=.png&file-filters%5B%5D=.puml&file-filters%5B%5D=.txt&file-filters%5B%5D=dotfile#diff-d23c8091515dc18149f4f2e759e1e288[MoneyGoWhere]]
*** Contributed to forum: [https://github.com/nus-cs2103-AY1920S1/forum/issues/73[library request]]
Expand Down Expand Up @@ -91,3 +92,4 @@ include::../DeveloperGuide.adoc[tag=Ui]

include::../DeveloperGuide.adoc[tag=autocomplete]

include::../DeveloperGuide.adoc[tag=uc02]
8 changes: 6 additions & 2 deletions src/main/java/seedu/address/ui/MainWindow.java
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,14 @@ private CommandResult executeCommand(String commandText) throws CommandException
logger.info("Study plan has been changed. Refreshing display.");
if (sp == null) {
NoActiveStudyPlanDisplay noActiveStudyPlanDisplay = new NoActiveStudyPlanDisplay();
semesterListPanelPlaceholder.getChildren().remove(0);
if (semesterListPanelPlaceholder.getChildren().size() != 0) {
semesterListPanelPlaceholder.getChildren().remove(0);
}
semesterListPanelPlaceholder.getChildren().add(noActiveStudyPlanDisplay.getRoot());
studyPlanId.setText("");
studyPlanTagsPlaceholder.getChildren().remove(0);
if (studyPlanTagsPlaceholder.getChildren().size() != 0) {
studyPlanTagsPlaceholder.getChildren().remove(0);
}
title.setText(NO_ACTIVE_STUDY_PLAN);
} else {
ObservableList<Semester> semesters = sp.getSemesters().asUnmodifiableObservableList();
Expand Down
10 changes: 1 addition & 9 deletions src/main/java/seedu/address/ui/NoActiveStudyPlanDisplay.java
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
package seedu.address.ui;

import static java.util.Objects.requireNonNull;

import javafx.fxml.FXML;
import javafx.scene.control.TextArea;
import javafx.scene.layout.Region;

/**
* A ui for the status bar that is displayed at the header of the application.
* A display when there is no active study plan.
*/
public class NoActiveStudyPlanDisplay extends UiPart<Region> {

private static final String FXML = "NoActiveStudyPlanDisplay.fxml";
private static final String NO_ACTIVE_STUDY_PLAN = "You can create a new study plan with the command:\n"
+ "- newplan\n"
Expand All @@ -24,9 +21,4 @@ public NoActiveStudyPlanDisplay() {
noActiveStudyPlanString.setText(NO_ACTIVE_STUDY_PLAN);
}

public void setFeedbackToUser(String feedbackToUser) {
requireNonNull(feedbackToUser);
noActiveStudyPlanString.setText(feedbackToUser);
}

}
1 change: 0 additions & 1 deletion src/main/resources/view/DarkTheme.css
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,6 @@
-fx-opacity: 0.9;
}


.scroll-pane > .viewport {
-fx-background-color: transparent;
}
Expand Down

0 comments on commit 0c90ed5

Please sign in to comment.