Branch ui #109
Branch ui #109
Conversation
| } | ||
|
|
||
| Person personToExpand = lastShownList.get(index.getZeroBased()); | ||
| model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS); |
There was a problem hiding this comment.
I think this line should be removed since it negates search result. For instance, if I first search for all people with the surname 'Tan' with findperson tan, it gives me a list of everyone with the surname 'Tan'. Then if I choose to expand a person with expandperson 1, it expands the person, but the filtered list goes back to showing everyone in the address book. If the person is trying to review each person in a particular find query then it could be inconvenient for him. I'm not sure haha what do the rest of you guys think?
| } | ||
|
|
||
| Policy policyToExpand = lastShownList.get(index.getZeroBased()); | ||
| model.updateFilteredPolicyList(PREDICATE_SHOW_ALL_POLICIES); |
|
Hey Yiyin! This is super super impressive haha great work with the JavaFX. Just one comment though, when I try to update information about a person that's already expanded, or any of the policies that he possesses, the expanded card doesn't update. The same thing with the expanded policies. Thanks :) |
Add right panel
Add expand person command and expand policy command