Update developer guide, add PPP and fix bugs #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into chowyiyin-branch-v1.4-final
…into branch-v1.4-final
…into chowyiyin-branch-v1.4-final
…into chowyiyin-branch-v1.4-final
olivercheok20
changed the title
| || commandResult.isExpandPerson() | ||
| || commandResult.isExpandPolicy() | ||
| || commandResult.isListHistory(); |
There was a problem hiding this comment.
Just curious, but is there no other way to fix this issue?
Comment on lines
-21
to
+19
| .anyMatch(keyword -> StringUtil.containsWordIgnoreCase(person.getName().fullName, keyword)); | ||
| .anyMatch(keyword -> person.getName().fullName.toLowerCase().contains(keyword.toLowerCase())); |
There was a problem hiding this comment.
Maybe you can change this in the StringUtil::containsWordIgnoreCase function to maintain the same level of abstraction?
There was a problem hiding this comment.
Fixed in the latest commit :)
|
This PR, other than the comments I made, has Yiyin's commits (which are already merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.