Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run pe fixes #188

Merged

Conversation

francislow
Copy link

part of #183 #186

Copy link

@gabrielchao gabrielchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than some very minor typos.

docs/userguide/AutoComplete.adoc Outdated Show resolved Hide resolved
docs/userguide/AutoComplete.adoc Outdated Show resolved Hide resolved
docs/userguide/AutoComplete.adoc Outdated Show resolved Hide resolved
docs/userguide/AutoComplete.adoc Outdated Show resolved Hide resolved
docs/userguide/AutoComplete.adoc Outdated Show resolved Hide resolved
francislow and others added 5 commits November 3, 2019 21:08
Co-Authored-By: gabrielchao <42672580+gabrielchao@users.noreply.github.com>
Co-Authored-By: gabrielchao <42672580+gabrielchao@users.noreply.github.com>
Co-Authored-By: gabrielchao <42672580+gabrielchao@users.noreply.github.com>
Co-Authored-By: gabrielchao <42672580+gabrielchao@users.noreply.github.com>
Co-Authored-By: gabrielchao <42672580+gabrielchao@users.noreply.github.com>
Copy link

@gabrielchao gabrielchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@francislow francislow merged commit f4fa088 into AY1920S1-CS2103-F10-1:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants