Add tabs for data panels and also change CSS #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielchao
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Looks good. To confirm, is it right to say that all UiParts for the different commands from now on are to be put into the dataPanelsTabPane with the dataPanelsTabPaneManager updated with the appropriate setter method? So the role of the list command would be to indirectly call changeToPatientTab(), and if I were to add a UiPart to display the history, I would add the part as a Tab in the TabPane?
25 tasks
|
Yes correct! This can be more clearly seen in the PR in #75 . |
|
Closed as this has been merged into #75 (which contains a fix and example implementation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have merged this into my branch-ongoing-visits due to time constraints.