WIP: New comp features #113
Conversation
| @@ -26,7 +26,7 @@ | |||
| * and returns an AddPersonCommand object for execution. | |||
| * @throws ParseException if the user input does not conform the expected format | |||
| */ | |||
| public AddPersonCommand parse(String args) throws ParseException { | |||
| public AddPersonCommand parse(String args) throws ParseException, java.text.ParseException { | |||
There was a problem hiding this comment.
Is parse exception different from java.text.parse.exception? If there is no difference, please remove the duplicate.
There was a problem hiding this comment.
There's a difference. From what I understand from the code base, a pure parse exception captures invalid user inputs and it extends from IllegalValueException. While java.text.parse exception extends Exception and captures error related to format issues for the Date objects.
| @@ -118,6 +119,8 @@ private Model initModelManager(Storage storage, ReadOnlyUserPrefs userPrefs) { | |||
| initialPersonData = new Data(); | |||
| initialCompetitionData = new Data(); | |||
| initialParticipationData = new Data(); | |||
| } catch (ParseException e) { | |||
| e.printStackTrace(); | |||
There was a problem hiding this comment.
i think if you catch the parse exception, you should send a message and reinitialize the data to:
initialPersonData = new Data();
initialCompetitionData = new Data();
initialParticipationData = new Data();
in the catch block
| return false; | ||
|
|
There was a problem hiding this comment.
this can be shortened to a single line:
return startDate.equals(endDate) || startDate.dateObj.before(endDate.dateObj)
| requireNonNull(date); | ||
| checkArgument(isValidDate(date.trim()), MESSAGE_CONSTRAINTS); | ||
| this.date = date.trim(); | ||
| SimpleDateFormat format = new SimpleDateFormat(DATE_FORMAT); | ||
| dateObj = format.parse(date); | ||
| } |
There was a problem hiding this comment.
so this constructor is good.
but what you want to do for the tests is that you want to create another CustomDate constructor:
public CustomDate(Date dateObj) {
requireNonNull(dateObj);
// rest of code
}
that doesnt throw a parse exception, so that you dont have to trhow the parseexceptions all over the code base especially in the tests and sample data util
issue 65 fixed