Skip to content

Commit

Permalink
Yet another PPP update (#217)
Browse files Browse the repository at this point in the history
* Fixed Tutorial.setStudent() and EditCommandTest

* Update user guide

* Updated user guide

* Fixed setStudent() and EditCommand yet again

* Fixed bugs
fixed: included prefix mat_no and nusid in argmultimap for addstudentcommandparser
fixed: added issameperson() in Student which is called in contains in UniquePersonList which is called in addstudent/hasstudent in application, changed message_duplicate_student to reflect the new logic
changed: error messages (invalid ... in ...) to for better comprehension
changed: command usage messages for better comprehension
fixed: included conditional in application.setstudent() that does nothing if editedstudent and target are equal to avoid bug where student reference is changed in uniquepersonlist when the same student is added and removed
fixed: partialinputparsertest where by bob and amy had the same nusnetid and matricnums

* More bug fixes
fixed: changed assignment/tutname/eventname regex
fixed: display not a valid command, removed from Finder.java
fixed: optional[] no longer printed for optional fields in student.toString()
fixed: duplicateevents error not shown in console for addEventCommand

* Bug fixes:
fixed: import command whereby no error is shown in console when import https://nusmods.com/timetable/sem-1/share? is inputted
changed: import command message
changed: tutname regex to accept non white space characters

* Fixed listEvents bug
changed: displayassignmentscommand message usage - please update user guide
changed: studentnotfoundexception message in setassignmentscorecommand
fixed: did not throw error when setscore command is called for a student not in the tutorial

* Updated docs

* Patched setStudents - clearCommand and undoing deletion of students should work now

* Fixed SetSemStart Storage bug

* Added check to ensure tutorial duration is non-negative
Fixed storage for semStart

* Bug fixes
fixed: Error not thrown in application when application is changed but semstart is null
fixed: Error not thrown when invalid time is inputted for addTutorial (9999)
fixed: SuggestedCommands not set to an empty list when deleteSuggestedCommands is called - causes error to be thrown in terminal
when index is inputted after suggestedCommand.execute() throws an error

* Updated docs

* Updated docs

* PPP Update

* Final PPP Update
  • Loading branch information
ZiHawkEye committed Nov 11, 2019
1 parent 2cd4191 commit 0bf0527
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions docs/team/zihawkeye.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ The application will determine the dates of completed tutorials from the current
** The application relies on precached NUSMods data of all existing tutorials in AY 2019-2020, hence it does not rely on a internet connection.
Even then, the loading of the all the data into T.A.rence at initialization is not too computationally/memory intensive, without significant lag.
This is partly because extraneous elements (Lectures, Venues) have been filtered out in the cached data to reduce file size.
** Retrieval of NUSMods tutorials after the initialization is also efficient since the cached data is loaded into a data structure of nested HashMaps that has keys in the following order:
Module code, Semester, Lesson Type(Sectionals, Tutorials, Labs) and finally a unique ClassNo.
** The primary challenge in implementing the importing of tutorials was ensuring the compatibility between the cached data and the Tutorial Class already defined in Application.
This required delving into NUSMods data to understand the general structure of the JSON, as well as reading existing API documentation.

* Credits:
** NUS modules and tutorials data was retrieved from NUSMods database [link:https://api.nusmods.com/v2/2019-2020/[NUSMods]]
Expand All @@ -75,10 +79,6 @@ This is partly because extraneous elements (Lectures, Venues) have been filtered

== Contributions to the User Guide

|===
|_Given below are sections I contributed to the User Guide. They showcase my ability to write documentation targeting end-users._
|===

include::../UserGuide.adoc[tag=FeatureImport]

include::../UserGuide.adoc[tag=FeatureMarkAttendance]
Expand All @@ -91,10 +91,6 @@ include::../UserGuide.adoc[tag=FeatureSetSemStart]

== Contributions to the Developer Guide

|===
|_Given below are sections I contributed to the Developer Guide. They showcase my ability to write technical documentation and the technical depth of my contributions to the project._
|===

include::../DeveloperGuide.adoc[tag=model]

include::../DeveloperGuide.adoc[tag=MarkAttendanceFeature]
Expand Down

0 comments on commit 0bf0527

Please sign in to comment.