Skip to content

Commit

Permalink
Merge f705ff8 into 06ff494
Browse files Browse the repository at this point in the history
  • Loading branch information
Cary-Xx committed Oct 14, 2019
2 parents 06ff494 + f705ff8 commit 55dda71
Show file tree
Hide file tree
Showing 158 changed files with 3,236 additions and 3,343 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ dependencies {
}

shadowJar {
archiveName = 'addressbook.jar'
archiveName = 'MYMorise.jar'

destinationDir = file("${buildDir}/jar/")
}
Expand Down
2 changes: 1 addition & 1 deletion docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Each of the four components
* Defines its _API_ in an `interface` with the same name as the Component.
* Exposes its functionality using a `{Component Name}Manager` class.

For example, the `Logic` component (see the class diagram given below) defines it's API in the `Logic.java` interface and exposes its functionality using the `LogicManager.java` class.
For example, the `Logic` component (see the class diagram given below) defines its API in the `Logic.java` interface and exposes its functionality using the `LogicManager.java` class.

.Class Diagram of the Logic Component
image::LogicClassDiagram.png[]
Expand Down
2 changes: 1 addition & 1 deletion docs/diagrams/ArchitectureSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ activate model MODEL_COLOR
model -[MODEL_COLOR]-> logic
deactivate model

logic -[LOGIC_COLOR]> storage : saveAddressBook(addressBook)
logic -[LOGIC_COLOR]> storage : saveExpenseList(expenseList)
activate storage STORAGE_COLOR

storage -[STORAGE_COLOR]> storage : Save to file
Expand Down
19 changes: 9 additions & 10 deletions docs/diagrams/BetterModelClassDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,17 @@ skinparam arrowThickness 1.1
skinparam arrowColor MODEL_COLOR
skinparam classBackgroundColor MODEL_COLOR

AddressBook *-right-> "1" UniquePersonList
AddressBook *-right-> "1" UniqueTagList
UniqueTagList -[hidden]down- UniquePersonList
UniqueTagList -[hidden]down- UniquePersonList
ExpenseList *-right-> "1" UniqueExpenseList
ExpenseList *-right-> "1" UniqueTagList
UniqueTagList -[hidden]down- UniqueExpenseList
UniqueTagList -[hidden]down- UniqueExpenseList

UniqueTagList *-right-> "*" Tag
UniquePersonList o-right-> Person
UniqueExpenseList o-right-> Expense

Person o-up-> "*" Tag
Expense o-up-> "*" Tag

Person *--> Name
Person *--> Phone
Person *--> Email
Person *--> Address
Expense *--> Name
Expense *--> Amount
Expense *--> Date
@enduml
2 changes: 1 addition & 1 deletion docs/diagrams/DeleteSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ deactivate AddressBookParser
LogicManager -> DeleteCommand : execute()
activate DeleteCommand

DeleteCommand -> Model : deletePerson(1)
DeleteCommand -> Model : deleteExpense(1)
activate Model

Model --> DeleteCommand
Expand Down
6 changes: 3 additions & 3 deletions docs/diagrams/LogicClassDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package Logic {

package Parser {
Interface Parser <<Interface>>
Class AddressBookParser
Class MymParser
Class XYZCommandParser
Class CliSyntax
Class ParserUtil
Expand All @@ -35,8 +35,8 @@ Class HiddenOutside #FFFFFF
HiddenOutside ..> Logic

LogicManager .up.|> Logic
LogicManager -->"1" AddressBookParser
AddressBookParser .left.> XYZCommandParser: creates >
LogicManager -->"1" MymParser
MymParser .left.> XYZCommandParser: creates >

XYZCommandParser ..> XYZCommand : creates >
XYZCommandParser ..|> Parser
Expand Down
41 changes: 19 additions & 22 deletions docs/diagrams/ModelClassDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,22 @@ skinparam arrowColor MODEL_COLOR
skinparam classBackgroundColor MODEL_COLOR

Package Model <<Rectangle>>{
Interface ReadOnlyAddressBook <<Interface>>
Interface ReadOnlyExpenseList <<Interface>>
Interface Model <<Interface>>
Interface ObservableList <<Interface>>
Class AddressBook
Class ReadOnlyAddressBook
Class ExpenseList
Class ReadOnlyExpenseList
Class Model
Class ModelManager
Class UserPrefs
Class ReadOnlyUserPrefs

Package Person {
Class Person
Class Address
Class Email
Package Expense {
Class Expense
Class Amount
Class Date
Class Name
Class Phone
Class UniquePersonList
Class UniqueExpenseList
}

Package Tag {
Expand All @@ -32,25 +31,23 @@ Class Tag
Class HiddenOutside #FFFFFF
HiddenOutside ..> Model

AddressBook .up.|> ReadOnlyAddressBook
ExpenseList .up.|> ReadOnlyExpenseList

ModelManager .up.|> Model
Model .right.> ObservableList
ModelManager o--> "1" AddressBook
ModelManager o--> "1" ExpenseList
ModelManager o-left-> "1" UserPrefs
UserPrefs .up.|> ReadOnlyUserPrefs

AddressBook *--> "1" UniquePersonList
UniquePersonList o--> "*" Person
Person *--> Name
Person *--> Phone
Person *--> Email
Person *--> Address
Person *--> "*" Tag
ExpenseList *--> "1" UniqueExpenseList
UniqueExpenseList o--> "*" Expense
Expense *--> Name
Expense *--> Amount
Expense *--> Date
Expense *--> "*" Tag

Name -[hidden]right-> Phone
Phone -[hidden]right-> Address
Address -[hidden]right-> Email
Name -[hidden]right-> Amount
Amount -[hidden]right-> Date

ModelManager -->"1" Person : filtered list
ModelManager -->"1" Expense : filtered list
@enduml
14 changes: 7 additions & 7 deletions docs/diagrams/StorageClassDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,19 @@ skinparam classBackgroundColor STORAGE_COLOR

Interface Storage <<Interface>>
Interface UserPrefsStorage <<Interface>>
Interface AddressBookStorage <<Interface>>
Interface ExpenseListStorage <<Interface>>

Class StorageManager
Class JsonUserPrefsStorage
Class JsonAddressBookStorage
Class JsonExpenseListStorage

StorageManager .left.|> Storage
StorageManager o-right-> UserPrefsStorage
StorageManager o--> AddressBookStorage
StorageManager o--> ExpenseListStorage

JsonUserPrefsStorage .left.|> UserPrefsStorage
JsonAddressBookStorage .left.|> AddressBookStorage
JsonAddressBookStorage .down.> JsonSerializableAddressBookStorage
JsonSerializableAddressBookStorage .right.> JsonSerializablePerson
JsonSerializablePerson .right.> JsonAdaptedTag
JsonExpenseListStorage .left.|> ExpenseListStorage
JsonExpenseListStorage .down.> JsonSerializableExpenseList
JsonSerializableExpenseList .right.> JsonAdaptedExpense
JsonAdaptedExpense .right.> JsonAdaptedTag
@enduml
16 changes: 8 additions & 8 deletions docs/diagrams/UiClassDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ Class UiManager
Class MainWindow
Class HelpWindow
Class ResultDisplay
Class PersonListPanel
Class PersonCard
Class ExpenseListPanel
Class ExpenseCard
Class StatusBarFooter
Class CommandBox
}
Expand All @@ -33,25 +33,25 @@ UiManager -down-> MainWindow
MainWindow --> HelpWindow
MainWindow *-down-> CommandBox
MainWindow *-down-> ResultDisplay
MainWindow *-down-> PersonListPanel
MainWindow *-down-> ExpenseListPanel
MainWindow *-down-> StatusBarFooter

PersonListPanel -down-> PersonCard
ExpenseListPanel -down-> ExpenseCard

MainWindow -left-|> UiPart

ResultDisplay --|> UiPart
CommandBox --|> UiPart
PersonListPanel --|> UiPart
PersonCard --|> UiPart
ExpenseListPanel --|> UiPart
ExpenseCard --|> UiPart
StatusBarFooter --|> UiPart
HelpWindow -down-|> UiPart

PersonCard ..> Model
ExpenseCard ..> Model
UiManager -right-> Logic
MainWindow -left-> Logic

PersonListPanel -[hidden]left- HelpWindow
ExpenseListPanel -[hidden]left- HelpWindow
HelpWindow -[hidden]left- CommandBox
CommandBox -[hidden]left- ResultDisplay
ResultDisplay -[hidden]left- StatusBarFooter
Expand Down
6 changes: 3 additions & 3 deletions docs/diagrams/UndoRedoState0.puml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ skinparam ClassBorderColor #000000
title Initial state

package States {
class State1 as "__ab0:AddressBook__"
class State2 as "__ab1:AddressBook__"
class State3 as "__ab2:AddressBook__"
class State1 as "__mym1:ExpenseList__"
class State2 as "__mym2:ExpenseList__"
class State3 as "__mym3:ExpenseList__"
}
State1 -[hidden]right-> State2
State2 -[hidden]right-> State3
Expand Down
6 changes: 3 additions & 3 deletions docs/diagrams/UndoRedoState1.puml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ skinparam ClassBorderColor #000000
title After command "delete 5"

package States <<rectangle>> {
class State1 as "__ab0:AddressBook__"
class State2 as "__ab1:AddressBook__"
class State3 as "__ab2:AddressBook__"
class State1 as "__mym1:ExpenseList__"
class State2 as "__mym2:ExpenseList__"
class State3 as "__mym3:ExpenseList__"
}

State1 -[hidden]right-> State2
Expand Down
8 changes: 4 additions & 4 deletions docs/diagrams/UndoRedoState2.puml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
skinparam ClassFontColor #000000
skinparam ClassBorderColor #000000

title After command "add n/David"
title After command "add /n Coffee"

package States <<rectangle>> {
class State1 as "__ab0:AddressBook__"
class State2 as "__ab1:AddressBook__"
class State3 as "__ab2:AddressBook__"
class State1 as "__mym1:ExpenseList__"
class State2 as "__mym2:ExpenseList__"
class State3 as "__mym3:ExpenseList__"
}

State1 -[hidden]right-> State2
Expand Down
6 changes: 3 additions & 3 deletions docs/diagrams/UndoRedoState3.puml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ skinparam ClassBorderColor #000000
title After command "undo"

package States <<rectangle>> {
class State1 as "__ab0:AddressBook__"
class State2 as "__ab1:AddressBook__"
class State3 as "__ab2:AddressBook__"
class State1 as "__mym1:ExpenseList__"
class State2 as "__mym2:ExpenseList__"
class State3 as "__mym3:ExpenseList__"
}

State1 -[hidden]right-> State2
Expand Down
6 changes: 3 additions & 3 deletions docs/diagrams/UndoRedoState4.puml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ skinparam ClassBorderColor #000000
title After command "list"

package States <<rectangle>> {
class State1 as "__ab0:AddressBook__"
class State2 as "__ab1:AddressBook__"
class State3 as "__ab2:AddressBook__"
class State1 as "__mym1:ExpenseList__"
class State2 as "__mym2:ExpenseList__"
class State3 as "__mym3:ExpenseList__"
}

State1 -[hidden]right-> State2
Expand Down
8 changes: 4 additions & 4 deletions docs/diagrams/UndoRedoState5.puml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ skinparam ClassBorderColor #000000
title After command "clear"

package States <<rectangle>> {
class State1 as "__ab0:AddressBook__"
class State2 as "__ab1:AddressBook__"
class State3 as "__ab3:AddressBook__"
class State1 as "__mym1:ExpenseList__"
class State2 as "__mym2:ExpenseList__"
class State3 as "__mym3:ExpenseList__"
}

State1 -[hidden]right-> State2
Expand All @@ -17,5 +17,5 @@ State2 -[hidden]right-> State3
class Pointer as "Current State" #FFFFF

Pointer -up-> State3
note right on link: State ab2 deleted.
note right on link: State mym2 deleted.
@end
14 changes: 7 additions & 7 deletions docs/diagrams/UndoSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ end box

box Model MODEL_COLOR_T1
participant ":Model" as Model MODEL_COLOR
participant ":VersionedAddressBook" as VersionedAddressBook MODEL_COLOR
participant ":VersionedExpenseList" as VersionedExpenseList MODEL_COLOR
end box
[-> LogicManager : execute(undo)
activate LogicManager
Expand All @@ -30,15 +30,15 @@ deactivate AddressBookParser
LogicManager -> UndoCommand : execute()
activate UndoCommand

UndoCommand -> Model : undoAddressBook()
UndoCommand -> Model : undoExpenseList()
activate Model

Model -> VersionedAddressBook : undo()
activate VersionedAddressBook
Model -> VersionedExpenseList : undo()
activate VersionedExpenseList

VersionedAddressBook -> VersionedAddressBook :resetData(ReadOnlyAddressBook)
VersionedAddressBook --> Model :
deactivate VersionedAddressBook
VersionedExpenseList -> VersionedExpenseList :resetData(ReadOnlyExpenseList)
VersionedExpenseList --> Model :
deactivate VersionedExpenseList

Model --> UndoCommand
deactivate Model
Expand Down

0 comments on commit 55dda71

Please sign in to comment.