Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency update - Added JSON Support for Currency #77

Merged

Conversation

muhammadaljunied
Copy link

No description provided.

muhammadaljunied and others added 30 commits October 23, 2019 23:03
…into currency-update

* 'master' of https://github.com/AY1920S1-CS2103-T14-4/main:
  Revert "Fix"
  Fix
  Fix
  Prepare for release v1.2.1
  Update developer guide
  update developer guide diagrams
  update Developerguide
  update Userguide
  fixed checkstyle error
  fix checkstyle error
  Arrange
  fixed expenselist storage inside budget and checkstyle errors
  Fixed test cases for add budget
  Fix reading logic and caret selection issue
  Add autocomplete for user input
  added add budget function, checks to prevent budget period clashes, expenses to auto include into budget if date falls into budget period
  revert removeAddr merge
  Remove trailing white space from contactus doc
  safe delete Address class

# Conflicts:
#	docs/DeveloperGuide.adoc
#	src/main/java/seedu/address/MainApp.java
#	src/main/java/seedu/address/model/Model.java
#	src/main/java/seedu/address/model/ModelManager.java
#	src/main/java/seedu/address/model/UserPrefs.java
#	src/main/java/seedu/address/storage/Storage.java
#	src/main/java/seedu/address/storage/StorageManager.java
#	src/test/java/seedu/address/logic/LogicManagerTest.java
#	src/test/java/seedu/address/logic/commands/AddCommandIntegrationTest.java
#	src/test/java/seedu/address/logic/commands/AddCommandTest.java
#	src/test/java/seedu/address/logic/commands/ClearCommandTest.java
#	src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
#	src/test/java/seedu/address/logic/commands/EditCommandTest.java
#	src/test/java/seedu/address/logic/commands/FindCommandTest.java
#	src/test/java/seedu/address/logic/commands/ListCommandTest.java
#	src/test/java/seedu/address/model/ModelManagerTest.java
#	src/test/java/seedu/address/storage/StorageManagerTest.java
Cary-Xx and others added 19 commits November 1, 2019 01:41
…/main into Add_Budget

# Conflicts:
#	src/main/java/seedu/address/logic/Logic.java
#	src/main/java/seedu/address/logic/LogicManager.java
#	src/main/java/seedu/address/logic/commands/AddBudgetCommand.java
#	src/main/java/seedu/address/logic/commands/ClearCommand.java
#	src/main/java/seedu/address/logic/commands/CommandResult.java
#	src/main/java/seedu/address/logic/commands/DeleteCommand.java
#	src/main/java/seedu/address/logic/commands/EditBudgetCommand.java
#	src/main/java/seedu/address/logic/commands/EditCommand.java
#	src/main/java/seedu/address/logic/commands/ViewBudgetCommand.java
#	src/main/java/seedu/address/logic/commands/ViewBudgetListCommand.java
#	src/main/java/seedu/address/model/Model.java
#	src/main/java/seedu/address/model/ModelManager.java
#	src/main/java/seedu/address/model/budget/Budget.java
#	src/main/java/seedu/address/model/expense/Amount.java
#	src/main/java/seedu/address/model/expense/Expense.java
#	src/main/java/seedu/address/ui/MainWindow.java
#	src/main/java/seedu/address/ui/StatsDisplay.java
#	src/main/resources/view/MainWindow.fxml
#	src/test/java/seedu/address/logic/commands/AddCommandTest.java
#	src/test/java/seedu/address/testutil/BudgetBuilder.java
… periods, update edit command to show correct error message
…into currency-update

# Conflicts:
#	docs/UserGuide.adoc
-Added new logic for currency conversion
-Added Singleton to expose conversion data
…/main into currency-update

# Conflicts:
#	src/main/java/seedu/address/model/ModelManager.java
#	src/main/java/seedu/address/model/expense/Amount.java
#	src/main/java/seedu/address/model/expense/Currency.java
#	src/test/java/seedu/address/logic/commands/AddCommandTest.java
#	src/test/java/seedu/address/logic/commands/EditCommandTest.java
@Cary-Xx Cary-Xx added this to the v1.4 milestone Nov 6, 2019
@muhammadaljunied muhammadaljunied merged commit c5c7bf1 into AY1920S1-CS2103-T14-4:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants