Optimize GUI performance #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gary-lgy
force-pushed
the
gary/optimize
branch
2 times, most recently
from
ce7f3b9
to
75566d8
Compare
Previously, a MemeCard/TemplateCard/ImportMeme card is created anew whenever the GridCell is updated. This results in a lot of lagging and explosive memory usage because MemeCard/TemplateCard/ImportMeme reads the image from the disk everytime it is created. With this commit, MemeCard/TemplateCard/ImportMeme are cached in their parents and no repeated disk IO is made. Memory usage now is about 500MB for ~500 memes and does not increase when scrolling. The respective GridViews can scroll smoothly now. Tested with 1000 memes and no significant lag is observed.
gary-lgy
force-pushed
the
gary/optimize
branch
from
75566d8
to
948d58d
Compare
jonchan51
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a
MemeCard/TemplateCard/ImportMemecard is created anewwhenever the
GridCellis updated. This results in a lot of lagging andexplosive memory usage when scrolling because scrolling updates the
GridCellandMemeCard/TemplateCard/ImportMemereadsthe image from the disk in their constructors. (Imagine if the user is using HDD)
With this commit,
MemeCard/TemplateCard/ImportMemeare cached in theirparents and no repeated disk IO is made. Memory usage now is about 500MB
for ~500 memes and does not increase when scrolling.
The respective
GridViewscan scroll smoothly now. Tested with 1000 memesand no significant lag is observed.
Demo: (the screen recorder was consuming a lot of resources, actual performance should be better than this)
